Flash alert refresh

[simurai]

This refreshes the .flash alerts. Before | After. Changes include:

• Tweaked colors
• Tweaked octicons
• Tweaked close button
• Action button border

API changes

• None

/cc @primer/ds-core

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/irulxxlnz
✅ Preview: https://primer-css-git-next-4.primer.now.sh

[auareyou]

🙌

[auareyou]

Looks good!

[vdepizzol]

@simurai @auareyou I guess the dismiss icons need to pass AA contrast requirements since they're actionable elements? ✌️

[auareyou]

@simurai @auareyou I guess the dismiss icons need to pass AA contrast requirements since they're actionable elements? ✌️

For icons the requirement is 3:1 so these are fine! :) @vdepizzol

[simurai]

For icons the requirement is 3:1 so these are fine!

👍 Found this post: "The cross icon requires a contrast ratio of at least 3:1 against its background."

Looks like we're just above with all color variations.. here the default blue that has 3.12:1:

Ok, let's test this on dotcom. We're also considering a "high contrast" option where we could make the close button darker. There are probably a lot of other places where contrast isn't enough.