fix(Label): Add missing ref for Label without sx prop#6535
Merged
hussam-i-am merged 4 commits intomainfrom Aug 12, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: feb3c5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing ref forwarding issue in the Label component when the sx prop is not provided. The fix ensures that refs are properly passed through to the underlying DOM element in both code paths.
- Adds missing
refprop to the Component element in the non-sx branch
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
TylerJDev
approved these changes
Aug 8, 2025
joshblack
approved these changes
Aug 8, 2025
jonrohan
approved these changes
Aug 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6534
Changelog
New
Changed
Passes
refto child component ofLabelwhen there is nosxprop being passed in.Removed
Rollout strategy
Testing & Reviewing
Merge checklist