refactor(SubNav): Remove sx support from SubNav component#6602
refactor(SubNav): Remove sx support from SubNav component#6602
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 5d20042 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/396632 |
|
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the sx prop support from the SubNav component, replacing the internal BoxWithFallback implementation with standard HTML elements. This is part of a larger migration away from styled-system props to reduce bundle size and improve performance.
Key changes:
- Removes
sxprop support from SubNav, SubNavLinks, and SubNavLink components - Replaces
BoxWithFallbackwrapper with native HTML elements (nav,div,a) - Updates TypeScript interfaces to remove
SxPropdependencies
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/SubNav/SubNav.tsx | Main refactor removing sx support and BoxWithFallback usage |
| packages/react/src/SubNav/SubNav.dev.stories.tsx | Removes development stories demonstrating sx usage |
| e2e/components/SubNav.test.ts | Removes visual regression tests for sx-related stories |
| .changeset/proud-chairs-study.md | Documents breaking change for major version release |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Changelog
New
Changed
Removed
Remove sx support from SubNav component
Rollout strategy
Testing & Reviewing
Merge checklist