Skip to content

fix: add mini-throttle as dep to packages/react#6604

Merged
joshblack merged 2 commits intomainfrom
fix/add-mini-throttle-as-dep
Aug 14, 2025
Merged

fix: add mini-throttle as dep to packages/react#6604
joshblack merged 2 commits intomainfrom
fix/add-mini-throttle-as-dep

Conversation

@joshblack
Copy link
Copy Markdown
Member

This came up in Slack that certain bundler setups fail to resolve the @github/mini-throttle dependency. It turned out that this dependency was used in @primer/react but was not included in package.json which meant that our rollup config did not treat it as external. As a result, it was included in lib-esm/node_modules.

This PR adds the dependency to primer/react and also adjusts some of the github-ui ranges to be more inclusive of versions

Changelog

New

Changed

  • Add @github/mini-throttle to deps
  • Adjust ranges of github packages to be more inclusive of. versions

Removed

Rollout strategy

  • Patch release

Copilot AI review requested due to automatic review settings August 14, 2025 15:23
@joshblack joshblack requested a review from a team as a code owner August 14, 2025 15:23
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 14, 2025

🦋 Changeset detected

Latest commit: 7f88f39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.15 KB (0%)
packages/react/dist/browser.umd.js 90.34 KB (0%)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bundling issue where the @github/mini-throttle dependency was being used in the codebase but not properly declared as a dependency, causing certain bundler setups to fail resolution. The fix adds the missing dependency and updates the version range format for better compatibility.

  • Add @github/mini-throttle as an explicit dependency to prevent bundling issues
  • Update @github/tab-container-element version range to use caret notation for better version flexibility

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/package.json Adds missing @github/mini-throttle dependency and updates version range format for @github/tab-container-element
.changeset/stale-wasps-smell.md Documents the dependency addition as a patch release

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@joshblack joshblack added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 77a60e7 Aug 14, 2025
53 of 54 checks passed
@joshblack joshblack deleted the fix/add-mini-throttle-as-dep branch August 14, 2025 18:02
@primer primer bot mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants