fix: add mini-throttle as dep to packages/react#6604
Conversation
🦋 Changeset detectedLatest commit: 7f88f39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bundling issue where the @github/mini-throttle dependency was being used in the codebase but not properly declared as a dependency, causing certain bundler setups to fail resolution. The fix adds the missing dependency and updates the version range format for better compatibility.
- Add
@github/mini-throttleas an explicit dependency to prevent bundling issues - Update
@github/tab-container-elementversion range to use caret notation for better version flexibility
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/package.json | Adds missing @github/mini-throttle dependency and updates version range format for @github/tab-container-element |
| .changeset/stale-wasps-smell.md | Documents the dependency addition as a patch release |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This came up in Slack that certain bundler setups fail to resolve the
@github/mini-throttledependency. It turned out that this dependency was used in@primer/reactbut was not included inpackage.jsonwhich meant that our rollup config did not treat it as external. As a result, it was included inlib-esm/node_modules.This PR adds the dependency to primer/react and also adjusts some of the github-ui ranges to be more inclusive of versions
Changelog
New
Changed
@github/mini-throttleto depsRemoved
Rollout strategy