Fix maxWidths in theme not being applied#662
Merged
emplums merged 2 commits intoprimer:majorfrom Mar 25, 2020
dcastil:patch-2
Merged
Fix maxWidths in theme not being applied#662emplums merged 2 commits intoprimer:majorfrom dcastil:patch-2
emplums merged 2 commits intoprimer:majorfrom
dcastil:patch-2
Conversation
In the styled-system v5.0.0 Changelog `theme.maxWidths` was replaced by `theme.sizes` https://github.com/styled-system/styled-system/blob/master/CHANGELOG.md#v500-2019-06-02 This commit replaces the deprecated key so setting props like `maxWidth="medium"` works again.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/c7akl86zm |
Contributor
Author
Verify fix
The same doesn't work on https://primer.style/components/BorderBox |
dcastil
changed the title
emplums
approved these changes
Jan 13, 2020
emplums
left a comment
emplums
left a comment
There was a problem hiding this comment.
This looks good! Please hold off on merging until we've got a major release branch ready as this will be a breaking change for users of our theme! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the styled-system v5.0.0 Changelog
theme.maxWidthswas replaced bytheme.sizes. This PR replaces the deprecated key so setting props likemaxWidth="medium"works again.Closes: #734
Merge checklist
index.d.ts) if necessary