Skip to content

Add missing changes in 17.0.0#758

Closed
acknosyn wants to merge 5 commits intoprimer:masterfrom
acknosyn:fix/add-missing-changes-in-17.0.0
Closed

Add missing changes in 17.0.0#758
acknosyn wants to merge 5 commits intoprimer:masterfrom
acknosyn:fix/add-missing-changes-in-17.0.0

Conversation

@acknosyn
Copy link
Copy Markdown
Contributor

Some changes in release 17.0.0 were mistakenly left out. I explain everything in #757.

Closes #757.

🔨 Fix

…dow"

Update box shadow to match Primer CSS Next

- (Edit) add commit b8b43c, minus conflicts from recent changes to files
…der-extraction"

Extract Dialog header into separate component

- (Edit) add commit be6ed3
…github.com/taylorcjohnson/components into taylorcjohnson-taylorcjohnson-heading-update"

- (Edit) add commit 98af42
- (Edit) add commit 444679, minus conflicts from recent changes to files
- (Edit) add commit fbd493
@vercel vercel bot temporarily deployed to Preview April 14, 2020 08:41 Inactive
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-components/g75xwyybs
✅ Preview: https://primer-compone-git-fork-acknosyn-fix-add-missing-changes-9e690f.primer.now.sh

@acknosyn
Copy link
Copy Markdown
Contributor Author

Nice, you can see the updated docs preview now has the Heading content changes.

@emplums
Copy link
Copy Markdown

emplums commented Apr 14, 2020

Wowwww thanks so much for catching this and for the really amazing writeup in #757! This is fantastic sleuthing! 🙌 We will get this merged in and released today ✨

@BinaryMuse
Copy link
Copy Markdown
Contributor

@acknosyn Just wanted to echo what @emplums said — thank you very much and nice work tracking this down.

@vercel vercel bot temporarily deployed to Preview April 14, 2020 17:38 Inactive
@BinaryMuse
Copy link
Copy Markdown
Contributor

This is merged into #759 for a pending release. Thanks again!

@BinaryMuse BinaryMuse closed this Apr 14, 2020
@BinaryMuse BinaryMuse mentioned this pull request Apr 14, 2020
3 tasks
@acknosyn
Copy link
Copy Markdown
Contributor Author

Awesome! Glad I was able to contribute for the first time. Keep up the great work 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some changes in release 17.0.0 were mistakenly left out

3 participants