Merged
Conversation
Update box shadow to match Primer CSS Next - (Edit) add commit b8b43c, minus conflicts from recent changes to files
…traction" Extract Dialog header into separate component - (Edit) add commit be6ed3
…github.com/taylorcjohnson/components into taylorcjohnson-taylorcjohnson-heading-update" - (Edit) add commit 98af42
- (Edit) add commit 444679, minus conflicts from recent changes to files
- (Edit) add commit fbd493
Add hooks linter
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/kared4kml |
Loosen 'as' prop for Heading
emplums
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔨 Breaking changes
Some breaking changes that were meant to be included in v17.0.0 were mistakenly absent. Those changes are included in this release, and the v17.0.0 release notes have been edited to reflect the changes included in that release. Big thanks to @acknosyn for catching and fixing this. (#757, #758)
Dialogcomponents no longer render with a header by default. Extract Dialog header into separate component #736 @BinaryMuseMigration strategy: change any
Dialogcomponent with atitleprop set as follows:to
Headingnow renders anh2by default instead of anh1Heading update (new default level and updated docs) #716 @taylorcjohnsonMigration strategy: change any use of the
Headingcomponent without anasprop:to
🐛 Bug Fixes