Gitattributes#2484
Closed
Zalastax wants to merge 2 commits into
Closed
Conversation
This was referenced Jan 3, 2018
Member
|
i don't have enough information about this one to see why this is necessary or how it fits with #2505. i'd prefer to leave as is now and rely on developers to set their settings manually. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds .gitattributes to ensure that everyone performs automatic EOL conversion.
Also removes the line endings setting from the editorconfig, since it should be platform specific.
Replaces #2431.
I'll also add to the development wiki that Windows users are recommended to perform their pull requests using
git clone git@github.com:YOUR_USERNAME/p5.js.git --config core.autocrlf=true. With the default command, a user like me could have accidentally turned off autocrlf. Having autocrlf off means that sample-linter breaks.@Spongman looks OK?
Any precommit hook or similar that can ensure no CRLF gets commited?