Skip to content

Normalize line endings in sample-linter#2505

Closed
Zalastax wants to merge 1 commit into
processing:masterfrom
Zalastax:normalize-sample-linter
Closed

Normalize line endings in sample-linter#2505
Zalastax wants to merge 1 commit into
processing:masterfrom
Zalastax:normalize-sample-linter

Conversation

@Zalastax

@Zalastax Zalastax commented Jan 6, 2018

Copy link
Copy Markdown
Member

Prevents accidental mixing of line endings if the repo is checked out with autocrlf=false on Windows.
Replaces #2431 and solves the same problem as #2484. This can optionally be combined with #2484.

I've tested this with both autocrlf=false and autocrlf=true.
@Spongman what do you think?

This prevents accidental mixing of line endings if the repo is checked out with autocrlf=false on Windows
@Zalastax

Zalastax commented Jan 6, 2018

Copy link
Copy Markdown
Member Author

I think that #2484 must be included even if this is merged. The reason being that .editorconfig has to be changed to not enforce '\n'. Without that change, any editor that supports editorconfig will keep writing '\n' even though the repo uses autocrlf.

@lmccart

lmccart commented Feb 12, 2018

Copy link
Copy Markdown
Member

@Spongman I'm not very familiar with what this is doing but I see that you and @Zalastax were discussing previously on another thread. can you offer a recommendation on how best to proceed with this PR and also #2484?

@lmccart

lmccart commented Feb 12, 2018

Copy link
Copy Markdown
Member

I guess my general approach would be to do the minimal structuring needed to make things work ok for people, rather than going further toward enforcing particular ways of working. but I don't know how this plays out in this case exactly.

@lmccart

lmccart commented Mar 19, 2018

Copy link
Copy Markdown
Member

i don't have enough information about this one to see why this is necessary or how it fits with #2484. i'd prefer to leave as is now and rely on developers to set their settings manually.

@lmccart lmccart closed this Mar 19, 2018
@lmccart lmccart mentioned this pull request Mar 19, 2018
@Zalastax
Zalastax deleted the normalize-sample-linter branch June 15, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants