Add functions to convert to dry bulb temperature or humidity ratio from enthalpy#23
Merged
Add functions to convert to dry bulb temperature or humidity ratio from enthalpy#23
Conversation
-> GetTDryBulbFromEnthalpyAndHumRatio
…pyAndTDryBulb merge GetHumRatioFromEnthalpyAndTDryBulb to GetTDryBulbFromEnthalpyAndHumRatio brach
didierthevenard
requested changes
Feb 24, 2019
dmey
commented
Feb 24, 2019
Contributor
Author
dmey
left a comment
dmey
left a comment
There was a problem hiding this comment.
All the typos 'rearranged for humidity ratio' or 'rearranged for temperature' have been fixed in all languages. The BoundedHumRatio variable and the comments about it have been removed as this are added by #24. The tests for GetTDryBulbFromEnthalpyAndHumRatio have been changed from relative to absolute. Note that the threshold has been set to 0.001 for the SI versions and 0.05 for IP (see below). Let me know if you are happy to leave it like that.
> assert psy.GetTDryBulbFromEnthalpyAndHumRatio(42.6168, 0.02) == pytest.approx(86, abs = 0.001)
E assert 85.97235615557699 == 86 ± 1.0e-03
E -85.97235615557699
E +86 ± 1.0e-03
didierthevenard
approved these changes
Mar 4, 2019
Contributor
didierthevenard
left a comment
didierthevenard
left a comment
There was a problem hiding this comment.
No issues found.
hongyuanjia
pushed a commit
to hongyuanjia/psychrolib
that referenced
this pull request
Feb 14, 2020
# |<---- Using a Maximum Of 50 Characters ---->| # Explain why this change is being made # |<---- Try To Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: Github issue psychrometrics#23 # --- COMMIT END --- # Type can be # feat (new feature) # fix (bug fix) # docs (changes to documentation) # style (formatting, missing semi colons, etc; no code change) # refactor (refactoring production code) # test (adding missing tests, refactoring tests; no production code change) # chore (updating grunt tasks etc; no production code change) # -------------------- # Remember to # Separate subject from body with a blank line # Limit the subject line to 50 characters # Capitalize the subject line # Do not end the subject line with a period # Use the imperative mood in the subject line # Wrap the body at 72 characters # Use the body to explain what and why vs. how # Can use multiple lines with "-" for bullet points in body # -------------------- # For more information about this template, check out # https://gist.github.com/adeekshith/cd4c95a064977cdc6c50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 function in each to calculate dry bulb temperature or humidity ration from enthalpy as detailed in #10 (named
GetTDryBulbFromEnthalpyAndHumRatioandGetTDryBulbFromEnthalpyAndHumRatio).In this PR I have also added the source code for the excel tests under
tests/vba/test_psychrolib_ip.basandtests/vba/test_psychrolib_si.basas it will make it easier to edit them.Manual excel artefacts updated with updated PsychroLib and tests. All tests (including manual VBA passs).
@didierthevenard can you please review this and let me know for any issues -- I will send you a sperate PR for tightening the checks but please approve this first.