Conversation
rquitales
approved these changes
May 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 79.56% 79.37% -0.19%
==========================================
Files 16 17 +1
Lines 729 737 +8
==========================================
+ Hits 580 585 +5
- Misses 84 88 +4
+ Partials 65 64 -1 ☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v1.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VictoriaMetrics CRD includes a property like this:
which breaks codegen because the property name camel cases to "", and as a result we generates a bunch of unnamed functions.
This PR modifies our logic to ignore unnamed properties like this.
We also bump pu/pu and apimachinery for good measure.
Fixes #133.