Skip to content

Ignore unnamed properties #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blampe merged 5 commits into from
May 14, 2024
Merged

Ignore unnamed properties #135

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69fedf0
Ignore unnamed properties
blampe May 14, 2024
82181a5
changelog
blampe May 14, 2024
5ad2e1d
fix setup-go
blampe May 14, 2024
f26a639
Merge branch 'master' of github.com:pulumi/crd2pulumi into blampe/vm
blampe May 14, 2024
7b48758
camel var
blampe May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
camel var
  • Loading branch information
@blampe
blampe committed May 14, 2024
commit 7b48758a1098fded544e7aab2b7e09ac878e03a2
5 changes: 3 additions & 2 deletions pkg/codegen/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,14 +140,15 @@ func AddType(schema map[string]any, name string, types map[string]pschema.Comple
propertySpecs := map[string]pschema.PropertySpec{}
for propertyName := range properties {
// Ignore unnamed properties like "-".
if strcase.ToCamel(propertyName) == "" {
camelCase := strcase.ToCamel(propertyName)
if camelCase == "" {
continue
}
propertySchema, _, _ := unstructured.NestedMap(properties, propertyName)
propertyDescription, _, _ := unstructured.NestedString(propertySchema, "description")
defaultValue, _, _ := unstructured.NestedFieldNoCopy(propertySchema, "default")
propertySpecs[propertyName] = pschema.PropertySpec{
TypeSpec: GetTypeSpec(propertySchema, name+strcase.ToCamel(propertyName), types),
TypeSpec: GetTypeSpec(propertySchema, name+camelCase, types),
Description: propertyDescription,
Default: defaultValue,
}
Expand Down