Configurable package namespaces/prefixes#247
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for configurable package namespaces/prefixes across language generators.
- Switches codegen entrypoints to accept CodegenSettings and propagates PackageNamespace.
- Adjusts output paths/names for Java, .NET, NodeJS, and Python based on namespace.
- Adds CLI flags to pass per-language namespaces/prefixes.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/codegen/python.go | Accepts CodegenSettings, sets pkg.Name/Namespace, and derives Python package dir from namespace/name. |
| pkg/codegen/nodejs.go | Accepts CodegenSettings and sets pkg.Name/Namespace for NodeJS codegen. |
| pkg/codegen/language.go | Introduces PackageNamespace setting. |
| pkg/codegen/java.go | Accepts CodegenSettings, sets pkg.Name/Namespace, computes namespace-based paths; minor debug prints and error handling changes. |
| pkg/codegen/golang.go | Accepts CodegenSettings; continues to set pkg.Name for Go. |
| pkg/codegen/dotnet.go | Accepts CodegenSettings, sets pkg.Name/Namespace; updates generated namespace handling for C#. |
| pkg/codegen/codegen.go | Updates GenerateFunc signature and call site to pass CodegenSettings. |
| cmd/root.go | Adds CLI flags for per-language namespace/prefix configuration. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Refactor to pass full CodegenSettings to GenerateFunc
Reviewed `crd2pulumi/pkg/codegen/java.go` and `pulumi-java` codegen sources. Found in `pulumi-java` `GeneratePackage` path: `generateModuleContextMap` sets `BasePackage` to "com." + sanitizeImport(p.Namespace()) + "." when `BasePackage` is empty and `pkg.Namespace` is non-empty. Since `crd2pulumi` sets `pkg.Namespace` to "com.pulumiverse", pulumi-java prepends its own "com." producing "com.com.pulumiverse" → double com in output paths. Fix is to explicitly set the Java PackageInfo BasePackage to the provided PackageNamespace so the pulumi-java defaulting logic doesn’t add an extra "com.".
ringods
force-pushed
the
configurable-package-names
branch
from
7c03541 to
2223242
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 75.98% 76.03% +0.04%
==========================================
Files 17 17
Lines 966 993 +27
==========================================
+ Hits 734 755 +21
- Misses 163 167 +4
- Partials 69 71 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
EronWright
reviewed
Oct 17, 2025
EronWright
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #246
Implemented according to the proposal I posted in #246.
Tested manually with the CertManager CRDs, with and without the new CLI option, for
nodejs,python,dotnetandjava. As it needs to be, without the namespace/prefix option, I could verify the default value was still used. With the new namespace/prefix option, the value was integrated correctly in the generated files.