-
Notifications
You must be signed in to change notification settings - Fork 17
Configurable package namespaces/prefixes #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b60a0bd
Add prefix/namespace property
ringods 6072b6b
NodeJS: pass a package namespace downstream
ringods e462892
Python: pass a package prefix (namespace) downstream
ringods 0ccad68
.NET: pass a package namespace downstream
ringods 2223242
Java: pass a package namespace downstream
ringods 46ea89a
Update CHANGELOG.md
ringods 1450d62
Fix test
ringods ba5c184
Configure local tools via mise
ringods fe045d5
Updated README.md including new namespace/prefix options.
ringods bf178b3
Use the .NET Namespace as is.
ringods b3fa6ce
Use `--javaBasePackage` rather than `--javaNamespace` to be more idio…
ringods bec27a5
Small change to `pythonPackageDir` only once.
ringods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Java: pass a package namespace downstream
Reviewed `crd2pulumi/pkg/codegen/java.go` and `pulumi-java` codegen sources. Found in `pulumi-java` `GeneratePackage` path: `generateModuleContextMap` sets `BasePackage` to "com." + sanitizeImport(p.Namespace()) + "." when `BasePackage` is empty and `pkg.Namespace` is non-empty. Since `crd2pulumi` sets `pkg.Namespace` to "com.pulumiverse", pulumi-java prepends its own "com." producing "com.com.pulumiverse" → double com in output paths. Fix is to explicitly set the Java PackageInfo BasePackage to the provided PackageNamespace so the pulumi-java defaulting logic doesn’t add an extra "com.".
- Loading branch information
commit 222324244fc46302af9914371c9ec0a190a3cc41
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.