Multicall to func

[goodboy]

For some weird reason the benchmark tests are turning out to be slightly slower for the _multicall cases?
I'm not sure if I'm testing something differently or if invoking 2 methods is faster then a single function?

I'm going to investigate deeper.

[RonnyPfannschmidt]

i wont be able to revie this this month, im of f the grid starting tommorow

[goodboy]

No worries ronny. Enjoy the blackout ;)

[goodboy]

Shrunk the range of hooks to use for benchmarking to get a simpler picture.

Seems performance is the same or better when looking at min times but sometimes the mean can be a bit slower. It's negligable enough that I think the code cleanup outweighs that downside.

I still don't get how instantiating _MultiCall + calling execute() can ever be faster then single func call.
If you guys see something I'm missing do point it out.

[goodboy]

@RonnyPfannschmidt @nicoddemus any opinions on this?

[nicoddemus]

I still don't get how instantiating _MultiCall + calling execute() can ever be faster then single func call.
If you guys see something I'm missing do point it out.

I took a look at both versions of the code and I can't explain it either. As you, I would expect minimal difference to be negligible, but I'm also surprised that it can be slower some times. How slower are we talking about here?

It's negligable enough that I think the code cleanup outweighs that downside.

I agree, great work! 👍