[doc] Mention __slots__ behavior in weakref.rst - #21061
Merged
Merged
Conversation
It took me longer than I expected to figure out why a random class I dealt with didn't support weak references. I believe this addition will make the __slots__/weakref interaction more discoverable to people having troubles with this. (Before this patch __slots__ was not mentioned in weakref documentation even once).
Contributor
Author
|
cc'ing @mdickinson @pganssle @berkerpeksag as you were involved in some of the most recent changes in this file – apologies if I'm being a nag. Let me know if there's a better person to ask to review this. |
Contributor
Author
|
cc @vstinner I'm happy to create a ticket on bugs.python.org if necessary. |
vstinner
reviewed
Oct 27, 2020
ambv
reviewed
Oct 6, 2021
ambv
added
skip issue
skip news
needs backport to 3.9
needs backport to 3.10
ambv
changed the title
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 6, 2021
It took me longer than I expected to figure out why a random class I dealt with didn't support weak references. I believe this addition will make the __slots__/weakref interaction more discoverable to people having troubles with this. (Before this patch __slots__ was not mentioned in weakref documentation even once). Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit b24b47e) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
|
GH-28772 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 6, 2021
It took me longer than I expected to figure out why a random class I dealt with didn't support weak references. I believe this addition will make the __slots__/weakref interaction more discoverable to people having troubles with this. (Before this patch __slots__ was not mentioned in weakref documentation even once). Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit b24b47e) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
|
GH-28773 is a backport of this pull request to the 3.9 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 6, 2021
It took me longer than I expected to figure out why a random class I dealt with didn't support weak references. I believe this addition will make the __slots__/weakref interaction more discoverable to people having troubles with this. (Before this patch __slots__ was not mentioned in weakref documentation even once). Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit b24b47e) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
ambv
pushed a commit
that referenced
this pull request
Oct 6, 2021
It took me longer than I expected to figure out why a random class I dealt with didn't support weak references. I believe this addition will make the __slots__/weakref interaction more discoverable to people having troubles with this. (Before this patch __slots__ was not mentioned in weakref documentation even once). Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit b24b47e) Co-authored-by: Jakub Stasiak <jakub@stasiak.at>
Contributor
|
Dzięki, Jakub! ✨ 🍰 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me longer than I expected to figure out why a random class
I dealt with didn't support weak references. I believe this addition
will make the slots/weakref interaction more discoverable to people
having troubles with this. (Before this patch slots was not
mentioned in weakref documentation even once).