conformance: make open TypedDict extra kwargs optional#2301
Merged
carljm merged 1 commit intoJun 5, 2026
Merged
Conversation
68e0010 to
4d8dbf9
Compare
JelleZijlstra
approved these changes
Jun 5, 2026
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Agree this seems exactly analogous to the change in #2272.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#2272 made errors optional when an extra keyword is passed to
**kwargs: Unpack[OpenTypedDict], modifying the expectation incallables_kwargs.py. Buttypeddicts_extra_items.pycontains the same case:This PR marks the duplicate case optional, for consistency with #2272.