Skip to content

conformance: make open TypedDict extra kwargs optional #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carljm merged 1 commit into from
Jun 5, 2026
+1 −2
Merged

conformance: make open TypedDict extra kwargs optional #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion conformance/results/ty/typeddicts_extra_items.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Line 49: Expected 1 errors
Line 67: Expected 1 errors
Line 73: Expected 1 errors
Line 109: Expected 1 errors
Line 143: Expected 1 errors
Line 174: Expected 1 errors
Line 215: Expected 1 errors
Line 222: Expected 1 errors
Expand Down
2 changes: 1 addition & 1 deletion conformance/tests/typeddicts_extra_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class MovieExtra(TypedDict, extra_items=int):
def unpack_no_extra(**kwargs: Unpack[MovieNoExtra]) -> None: ...
def unpack_extra(**kwargs: Unpack[MovieExtra]) -> None: ...

unpack_no_extra(name="No Country for Old Men", year=2007) # E: Unrecognized item
unpack_no_extra(name="No Country for Old Men", year=2007) # E?: Unrecognized item
unpack_extra(name="No Country for Old Men", year=2007) # OK

# > Notably, if the TypedDict type specifies ``extra_items`` to be read-only,
Expand Down