[ET-VK][11/n] copy_channel_offsets node#3351
Closed
yipjustin wants to merge 6 commits intogh/yipjustin/14/basefrom
Closed
[ET-VK][11/n] copy_channel_offsets node#3351yipjustin wants to merge 6 commits intogh/yipjustin/14/basefrom
yipjustin wants to merge 6 commits intogh/yipjustin/14/basefrom
Conversation
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3351
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7a25897 with merge base e5471a5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
yipjustin
added a commit
that referenced
this pull request
Apr 25, 2024
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) ghstack-source-id: 223879986 Pull Request resolved: #3351
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56554426 |
junpi3
approved these changes
Apr 26, 2024
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) [ghstack-poisoned]
yipjustin
added a commit
that referenced
this pull request
Apr 27, 2024
Pull Request resolved: #3351 1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) ghstack-source-id: 224194777
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56554426 |
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56554426 |
yipjustin
added a commit
that referenced
this pull request
Apr 27, 2024
Pull Request resolved: #3351 1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. ghstack-source-id: 224194953 Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/)
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56554426 |
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56554426 |
1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56554426 |
Contributor
|
This pull request has been merged in ae250c0. |
This was referenced Apr 29, 2024
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#3351 1. Add a node `copy_channel_offsets` specifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing. 1.1. `copy_channel_offsets` will be useful for `aten.cat` and `aten.split`. 2. Create `etvk.*` operators to facilitate testing. Add test case for both `copy_offset` and `copy_channel_offset`. ghstack-source-id: 224214136 Differential Revision: [D56554426](https://our.internmc.facebook.com/intern/diff/D56554426/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
copy_channel_offsetsspecifically for copying along the channel dimension, it needs extra attention at the boundaries due to channel packing.1.1.
copy_channel_offsetswill be useful foraten.catandaten.split.etvk.*operators to facilitate testing. Add test case for bothcopy_offsetandcopy_channel_offset.Differential Revision: D56554426