[ET-VK][13/n] split_with_sizes with more test codegen#3389
Closed
yipjustin wants to merge 3 commits intogh/yipjustin/16/basefrom
Closed
[ET-VK][13/n] split_with_sizes with more test codegen#3389yipjustin wants to merge 3 commits intogh/yipjustin/16/basefrom
yipjustin wants to merge 3 commits intogh/yipjustin/16/basefrom
Conversation
Life is fun when the code-gen is more challenging than writing the operator itself. 1. Test codegen update to include vector of Tensor as output: `Tensor(a)[]`. 2. `aten.split_with_sizes.default` 3. `aten.split.Tensor` 4. Improve `DimUtils` for better dimension reasoning. Differential Revision: [D56660525](https://our.internmc.facebook.com/intern/diff/D56660525/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3389
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 466d1ea with merge base 987a1f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Apr 27, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56660525 |
yipjustin
added a commit
that referenced
this pull request
Apr 27, 2024
Life is fun when the code-gen is more challenging than writing the operator itself. 1. Test codegen update to include vector of Tensor as output: `Tensor(a)[]`. 2. `aten.split_with_sizes.default` 3. `aten.split.Tensor` 4. Improve `DimUtils` for better dimension reasoning. Differential Revision: [D56660525](https://our.internmc.facebook.com/intern/diff/D56660525/) ghstack-source-id: 224195688 Pull Request resolved: #3389
Life is fun when the code-gen is more challenging than writing the operator itself. 1. Test codegen update to include vector of Tensor as output: `Tensor(a)[]`. 2. `aten.split_with_sizes.default` 3. `aten.split.Tensor` 4. Improve `DimUtils` for better dimension reasoning. Differential Revision: [D56660525](https://our.internmc.facebook.com/intern/diff/D56660525/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56660525 |
This was referenced Apr 29, 2024
SS-JIA
approved these changes
Apr 29, 2024
Life is fun when the code-gen is more challenging than writing the operator itself. 1. Test codegen update to include vector of Tensor as output: `Tensor(a)[]`. 2. `aten.split_with_sizes.default` 3. `aten.split.Tensor` 4. Improve `DimUtils` for better dimension reasoning. Differential Revision: [D56660525](https://our.internmc.facebook.com/intern/diff/D56660525/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D56660525 |
Contributor
|
This pull request has been merged in 8458e63. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#3389 Life is fun when the code-gen is more challenging than writing the operator itself. 1. Test codegen update to include vector of Tensor as output: `Tensor(a)[]`. 2. `aten.split_with_sizes.default` 3. `aten.split.Tensor` 4. Improve `DimUtils` for better dimension reasoning. ghstack-source-id: 224258792 @exported-using-ghexport Differential Revision: [D56660525](https://our.internmc.facebook.com/intern/diff/D56660525/)
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#3389 Life is fun when the code-gen is more challenging than writing the operator itself. 1. Test codegen update to include vector of Tensor as output: `Tensor(a)[]`. 2. `aten.split_with_sizes.default` 3. `aten.split.Tensor` 4. Improve `DimUtils` for better dimension reasoning. ghstack-source-id: 224398848 @exported-using-ghexport Differential Revision: [D56660525](https://our.internmc.facebook.com/intern/diff/D56660525/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Life is fun when the code-gen is more challenging than writing the operator itself.
Tensor(a)[].aten.split_with_sizes.defaultaten.split.TensorDimUtilsfor better dimension reasoning.Differential Revision: D56660525