Factor out eager val from eval_llama_lib#3756
Closed
cccclai wants to merge 5 commits intogh/cccclai/10/basefrom
Closed
Factor out eager val from eval_llama_lib#3756cccclai wants to merge 5 commits intogh/cccclai/10/basefrom
cccclai wants to merge 5 commits intogh/cccclai/10/basefrom
Conversation
Would like to re-use EagerEvalWrapper and eval function for quantization calibration. Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3756
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3483891 with merge base 757a6ad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57881028 |
cccclai
added a commit
that referenced
this pull request
May 28, 2024
Would like to re-use EagerEvalWrapper and eval function for quantization calibration. Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/) ghstack-source-id: 227994056 Pull Request resolved: #3756
Would like to re-use EagerEvalWrapper and eval function for quantization calibration. Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57881028 |
cccclai
added a commit
that referenced
this pull request
May 28, 2024
Pull Request resolved: #3756 Would like to re-use EagerEvalWrapper and eval function for quantization calibration. ghstack-source-id: 227999069 @exported-using-ghexport Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/)
Would like to re-use EagerEvalWrapper and eval function for quantization calibration. Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57881028 |
cccclai
added a commit
that referenced
this pull request
May 28, 2024
Pull Request resolved: #3756 Would like to re-use EagerEvalWrapper and eval function for quantization calibration. ghstack-source-id: 228001053 @exported-using-ghexport Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/)
This was referenced May 28, 2024
Would like to re-use EagerEvalWrapper and eval function for quantization calibration. Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57881028 |
Jack-Khuu
approved these changes
May 29, 2024
Contributor
Jack-Khuu
left a comment
Jack-Khuu
left a comment
There was a problem hiding this comment.
Thanks for the refactor, makes things easier to reference
|
|
||
| try: | ||
| from ...portable.utils import export_to_edge, save_pte_program | ||
| except ImportError: |
Contributor
There was a problem hiding this comment.
let's put this as a task to fix separately. I've seem this issue in other parts of the repo too
Contributor
Author
There was a problem hiding this comment.
Yeah makes sense. Let me update
Would like to re-use EagerEvalWrapper and eval function for quantization calibration. Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57881028 |
cccclai
added a commit
that referenced
this pull request
May 29, 2024
Pull Request resolved: #3756 Would like to re-use EagerEvalWrapper and eval function for quantization calibration. ghstack-source-id: 228123244 @exported-using-ghexport Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/)
Contributor
|
This pull request has been merged in fbbba34. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#3756 Would like to re-use EagerEvalWrapper and eval function for quantization calibration. ghstack-source-id: 228051127 @exported-using-ghexport Differential Revision: [D57881028](https://our.internmc.facebook.com/intern/diff/D57881028/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Would like to re-use EagerEvalWrapper and eval function for quantization calibration.
Differential Revision: D57881028