Switch the order of the to_dtype function and source transform#3757
Closed
cccclai wants to merge 3 commits intogh/cccclai/11/basefrom
Closed
Switch the order of the to_dtype function and source transform#3757cccclai wants to merge 3 commits intogh/cccclai/11/basefrom
cccclai wants to merge 3 commits intogh/cccclai/11/basefrom
Conversation
We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform. Differential Revision: [D57883363](https://our.internmc.facebook.com/intern/diff/D57883363/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3757
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0471900 with merge base 757a6ad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57883363 |
cccclai
added a commit
that referenced
this pull request
May 28, 2024
We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform. Differential Revision: [D57883363](https://our.internmc.facebook.com/intern/diff/D57883363/) ghstack-source-id: 228003406 Pull Request resolved: #3757
…form" We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform. Differential Revision: [D57883363](https://our.internmc.facebook.com/intern/diff/D57883363/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57883363 |
larryliu0820
approved these changes
May 29, 2024
…form" We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform. Differential Revision: [D57883363](https://our.internmc.facebook.com/intern/diff/D57883363/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D57883363 |
cccclai
added a commit
that referenced
this pull request
May 29, 2024
Pull Request resolved: #3757 We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform. ghstack-source-id: 228125529 Differential Revision: [D57883363](https://our.internmc.facebook.com/intern/diff/D57883363/)
Contributor
|
This pull request has been merged in 2badd76. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#3757 We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform. ghstack-source-id: 228051128 Differential Revision: [D57883363](https://our.internmc.facebook.com/intern/diff/D57883363/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We're running quantization during source transform and some quantization infra doesn't support bf16 yet. Move to_dtype one stage earlier so we can choose the dtype fp32 before running quantization transform.
Differential Revision: D57883363