Arm backend: add tosa_spec and et-version info to .tosa files#9308
Merged
zingo merged 4 commits intopytorch:mainfrom Mar 18, 2025
Merged
Arm backend: add tosa_spec and et-version info to .tosa files#9308zingo merged 4 commits intopytorch:mainfrom
zingo merged 4 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9308
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Cancelled Job, 1 PendingAs of commit b2288b3 with merge base b8a0edd ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
output_tag<N>.tosa is not very informative. Output files will now be named as output_tag<N>_<tosa_spec>_<et-version>.tosa instead. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I13d75f0c35a023a315283bc14e6de38e932d4f10
oscarandersson8218
force-pushed
the
tosa_files_naming
branch
from
80b568a to
056019e
Compare
zingo
approved these changes
Mar 18, 2025
Collaborator
|
Testfails are unrelated |
Contributor
|
This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message? |
larryliu0820
added a commit
that referenced
this pull request
Mar 18, 2025
Collaborator
Author
|
@larryliu0820 I re-submitted the PR in #9392 |
Collaborator
Hi could you help us point out what error you got from this, to help us knowing how to avoid this better in the future or even better could the internal tests be ported to be runned in github also so we can get proper testing while merging? |
oscarandersson8218
pushed a commit
to oscarandersson8218/executorch
that referenced
this pull request
Mar 21, 2025
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
…h#9308) Arm backend output files will now be named as output_tag<N>_<tosa_spec>_<et-version>.tosa instead of output_tag<N>.tosa. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
DannyYuyang-quic
pushed a commit
to CodeLinaro/executorch
that referenced
this pull request
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm backend output files will now be named as output_tag<tosa_spec>.tosa instead of output_tag.tosa.
cc @digantdesai @freddan80 @per @zingo