Arm backend: Add tosa_spec info to .tosa files by oscarandersson8218 · Pull Request #9392 · pytorch/executorch

oscarandersson8218 · 2025-03-19T07:16:40Z

Arm backend output files will now be named as output_tag<N>_<tosa_spec>.tosa instead of output_tag.tosa.

cc @digantdesai @freddan80 @per @zingo

pytorch-bot · 2025-03-19T07:16:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9392

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit fa1e3bb with merge base 644b7dd ():

NEW FAILURES - The following jobs have failed:

pull / unittest / macos / macos-job (gh)
backends/xnnpack/test/passes/test_convert_to_linear.py::TestConvertToLinear::test_fp32_convert_to_linear
pull / unittest-editable / macos / macos-job (gh)
backends/xnnpack/test/passes/test_convert_to_linear.py::TestConvertToLinear::test_fp32_convert_to_linear
trunk / test-arm-reference-delegation / linux-job (gh)
RuntimeError: Command docker exec -t 277a66e4623b5ce1660e680aa99a0de1f6158be60a502789458373aac75d3054 /exec failed with exit code 1
trunk / unittest-release / macos / macos-job (gh)
backends/xnnpack/test/passes/test_convert_to_linear.py::TestConvertToLinear::test_fp32_convert_to_linear

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zingo · 2025-03-19T09:58:54Z

Hi @larryliu0820

This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message?

Hi could you help us point out what error you got from this, to help us knowing how to avoid this better in the future or even better could the internal tests be ported to be runned in github also so we can get proper testing while merging?

facebook-github-bot · 2025-03-19T16:54:47Z

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

larryliu0820 · 2025-03-19T16:57:47Z

Hi @larryliu0820

This broke our internal tests and we need to revert it first. Could you please re-submit the PR, and wait for us to import and run internal CI, and paste the error message?

Hi could you help us point out what error you got from this, to help us knowing how to avoid this better in the future or even better could the internal tests be ported to be runned in github also so we can get proper testing while merging?

The original PR was failing all executorch/backends/arm/test tests internally. Haven't looked into the details of the tests and also not sure why it's not showing up in OSS CI. I reimported this retry PR and see if it passes this time.

zingo · 2025-03-19T18:59:29Z

This patch renames the tosa files could you have tests that assume some filenames?

larryliu0820 · 2025-03-19T19:02:40Z

This seems fine in terms of internal test

zingo · 2025-03-20T08:20:28Z

Hi @larryliu0820 does this mean we should go ahead and merge this again now? Or will you merge it to do the extended testing?

digantdesai · 2025-03-21T05:54:05Z


        if artifact_path:
            tag = _get_first_delegation_tag(graph_module)
+            et_version = version("executorch")


This is causing issues for internal setup, I need to take a look.

Thanks, This was merged and reverted during your days off and we were asked to reupload the PR. We don't know what caused the problem so the PR was unchanged. One suspicion we have is if you assume and tosa file names in some way in your flow that would break as they get renamed by this patch.

I need to take a better look at internal failures but this could be because of how packages are set up internally. Can we drop et_version for now?

Yes, that's fine for us.

oscarandersson8218 · 2025-03-21T13:18:37Z

I messed up the rebase a bit, hence all the added reviewers in the log. Sorry about that. PR should be in a good state again though.

digantdesai · 2025-03-21T15:37:03Z

LGTM, stamped. Let me pull internally just to be safe (re-revert would be bad :p) - should take a couple of hours. I can merge it if you don't mind.

facebook-github-bot · 2025-03-21T15:37:18Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

zingo · 2025-03-21T15:42:41Z

Thanks, please go ahead 🙏

facebook-github-bot · 2025-03-25T18:25:00Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2025-03-26T15:33:05Z

Ci failures related? Internal CI is happy.

oscarandersson8218 · 2025-03-26T15:36:57Z

Ci failures related? Internal CI is happy.

@digantdesai Don't think they are related. trunk/test-arm-reference-delegation/linux-job should be fixed by #9641

Arm backend output files will now be named as `output_tag<N>_<tosa_spec>.tosa` instead of `output_tag.tosa`. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>

oscarandersson8218 requested a review from digantdesai as a code owner March 19, 2025 07:16

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025

oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Mar 19, 2025

oscarandersson8218 mentioned this pull request Mar 19, 2025

Arm backend: add tosa_spec and et-version info to .tosa files #9308

Merged

larryliu0820 approved these changes Mar 19, 2025

View reviewed changes

digantdesai reviewed Mar 21, 2025

View reviewed changes

oscarandersson8218 requested review from Gasoonjia, GregoryComer, JacobSzwejbka, cccclai, cymbalrush, iseeyuan, jackzhxng, kimishpatel, lucylq, manuelcandales, mergennachin, metascroy, shoumikhin, swolchok and tarun292 as code owners March 21, 2025 12:31

oscarandersson8218 removed request for Gasoonjia, GregoryComer, JacobSzwejbka, SS-JIA, cccclai, cymbalrush, iseeyuan, jackzhxng, kimishpatel, kirklandsign, lucylq, manuelcandales, mcr229, mergennachin, metascroy, shoumikhin, swolchok and tarun292 March 21, 2025 13:13

zingo changed the title ~~Arm backend: Add tosa_spec and et-version info to .tosa files~~ Arm backend: Add tosa_spec info to .tosa files Mar 21, 2025

digantdesai approved these changes Mar 21, 2025

View reviewed changes

Merge branch 'main' into tosa_files_naming

fa1e3bb

zingo merged commit 07266f9 into pytorch:main Mar 27, 2025
162 of 166 checks passed

Conversation

oscarandersson8218 commented Mar 19, 2025 • edited by zingo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9392

❌ 4 New Failures

Uh oh!

zingo commented Mar 19, 2025

Uh oh!

facebook-github-bot commented Mar 19, 2025

Uh oh!

larryliu0820 commented Mar 19, 2025

Uh oh!

zingo commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

larryliu0820 commented Mar 19, 2025

Uh oh!

zingo commented Mar 20, 2025

Uh oh!

digantdesai Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

zingo Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

digantdesai Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

oscarandersson8218 Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

oscarandersson8218 commented Mar 21, 2025

Uh oh!

digantdesai commented Mar 21, 2025

Uh oh!

facebook-github-bot commented Mar 21, 2025

Uh oh!

zingo commented Mar 21, 2025

Uh oh!

facebook-github-bot commented Mar 25, 2025

Uh oh!

digantdesai commented Mar 26, 2025

Uh oh!

oscarandersson8218 commented Mar 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

oscarandersson8218 commented Mar 19, 2025 •

edited by zingo

Loading

pytorch-bot Bot commented Mar 19, 2025 •

edited

Loading

zingo commented Mar 19, 2025 •

edited

Loading