Pin CI python version#633
Merged
Merged
Conversation
NoureldinYosri
approved these changes
Oct 30, 2023
Collaborator
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
Looks like qsim's dependency on distuils is two folds.
- a superficial dependency in
setup.pyto getfrom distutils.version import LooseVersionwhich should be replaced byfrom packaging.version import parseas per https://peps.python.org/pep-0632/#migration-advice - A transitive depdency that happens due to a dependency on an old version of tensorflow.
So LGTM for now until we upgrade to a newer version of tf
NoureldinYosri
added a commit
that referenced
this pull request
Jan 24, 2024
The error #632 originally fixed in #633 has made a comeback https://fusion2.corp.google.com/invocations/f88845c0-24f7-4c02-b99d-74424ce80a75/targets/qsim%2Fmacos%2Fpresubmit/log. Fix: Replace `distutils` with `packaging` as per https://peps.python.org/pep-0632/#migration-advice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #632.
The python version for the
setup-pythonaction does not need to match the version used bycibuildwheel; it simply needs to be beforedistutilsgets removed in python 3.12.