Change method of getting json data out of HTTP requests#4349
Merged
rakanalh merged 1 commit intoraiden-network:developfrom Jul 8, 2019
lullis:4174_fix_requests_json_parsing
Merged
Change method of getting json data out of HTTP requests#4349rakanalh merged 1 commit intoraiden-network:developfrom lullis:4174_fix_requests_json_parsing
rakanalh merged 1 commit intoraiden-network:developfrom
lullis:4174_fix_requests_json_parsing
Conversation
|
|
The requests module has some undercover magic of using a different implementation depending on whether the simplejson package is installed, which makes the built-in requests.response.json() method unreliable To avoid this issue, we are removing all calls to response.json() and parsing the response using python's built-in json module.
Codecov Report
@@ Coverage Diff @@
## develop #4349 +/- ##
===========================================
+ Coverage 80.96% 81.03% +0.07%
===========================================
Files 105 105
Lines 13787 13793 +6
Branches 2115 2115
===========================================
+ Hits 11162 11177 +15
+ Misses 2028 2019 -9
Partials 597 597
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requests module has some undercover magic of using a different implementation
depending on whether the simplejson package is installed, which makes the built-in
requests.response.json() method unreliable
To avoid this issue, we are removing all calls to response.json() and parsing the
response using python's built-in json module.
Resolves #4174