Skip to content

Make diagram and caption consistent in Pagerank.ipynb#2207

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.06from
charlesbluca:fix-pagerank-caption
Apr 13, 2022
Merged

Make diagram and caption consistent in Pagerank.ipynb#2207
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.06from
charlesbluca:fix-pagerank-caption

Conversation

@charlesbluca
Copy link
Member

@charlesbluca charlesbluca commented Apr 7, 2022

Fixes some small inconsistencies between code blocks / diagrams and their associated captions in the Pagerank notebook. We might want to resolve the FutureWarning raised in from_cudf_edgelist first, as it crops up in the outputs (xref #2174).

Closes #2182

@charlesbluca charlesbluca requested a review from a team as a code owner April 7, 2022 13:28
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@charlesbluca charlesbluca changed the title Fix typo in Make diagram and caption consistent in Pagerank.ipynb Apr 7, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2022
@BradReesWork BradReesWork added this to the 22.06 milestone Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #2207 (9714431) into branch-22.06 (38be932) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2207      +/-   ##
================================================
+ Coverage         70.82%   70.86%   +0.04%     
================================================
  Files               170      170              
  Lines             11036    11036              
================================================
+ Hits               7816     7821       +5     
+ Misses             3220     3215       -5     
Impacted Files Coverage Δ
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38be932...9714431. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a838fc5 into rapidsai:branch-22.06 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Inaccurate caption in Pagerank.ipynb

3 participants