Define triangle_count C API#2271
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
ChuckHastings
added
improvement
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
LGTM (except for one comment about documentation).
| * @param [in] handle Handle for accessing resources | ||
| * @param [in] graph Pointer to graph. NOTE: Graph might be modified if the storage | ||
| * needs to be transposed | ||
| * @param [in] start Device array of vertices we want to count triangles for |
There was a problem hiding this comment.
Add a comment saying "if this is NULL, the entire set of vertices is assumed"?
There was a problem hiding this comment.
Will fix in next push.
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2271 +/- ##
=============================================
Coverage 63.97% 63.97%
=============================================
Files 100 100
Lines 4436 4436
=============================================
Hits 2838 2838
Misses 1598 1598 Continue to review full report at Codecov.
|
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
LGTM. I focused on the public API part and less on the (commented out) implementation. I had one questions which need not hold up approval.
| * the entire set of vertices in the graph is processed | ||
| * @param [in] do_expensive_check | ||
| * A flag to run expensive checks for input arguments (if set to true) | ||
| * @param [in] result Output from the triangle_count call |
There was a problem hiding this comment.
Why is result labelled in but error is an out? I figured they'd both be out.
There was a problem hiding this comment.
Good catch. Should both be out. I will correct in a follow-up PR.
|
@gpucibot merge |
Define triangle_count C API (rapidsai#2271)
4 participants
This defines the C API for triangle counting.
This PR is independent of #2253 and can be merged independently. The change here defines the C API and returns the
CUGRAPH_NOT_IMPLEMENTEDerror when called. Once #2253 is completed and merged, a follow-up PR will fill in the C API implementation for triangle counting (although the code is written and untested in this PR).