Implement two_hop_neighbors C API#2915
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.12from Nov 10, 2022
Merged
Implement two_hop_neighbors C API#2915rapids-bot[bot] merged 2 commits intorapidsai:branch-22.12from
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.12from
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
seunghwak
approved these changes
Nov 10, 2022
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Looks good to me but should we better generalize this for k-hop neighbors (maybe not right now)?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2915 +/- ##
===============================================
Coverage ? 60.72%
===============================================
Files ? 122
Lines ? 6856
Branches ? 0
===============================================
Hits ? 4163
Misses ? 2693
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
Author
|
Added #2918 to remind us to eventually expose the k-hop version of this. |
jnke2016
approved these changes
Nov 10, 2022
Collaborator
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the two hop neighbors C API using the k_hop_nbrs algorithm.
This should unblock #2704