You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As pointed out by @kelset on #34660 (comment) accessing the TransformExample is currently crashing the RNTester app due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string.
Changelog
[Internal] [Fixed] - Add missing translate units to RNTesterTransformExample
Test Plan
Open the RNTester app and navigate to the Transforms page
Check the transform style through the Transform using a string section
We should also make the failures yellowboxes not invariants
@necolas should we use yellowboxes even though we only show this error when running on DEV mode? We also do this inside the _validateTransforms function, should we update that as well?
PR build artifact for bcba275 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As pointed out by @kelset on #34660 (comment) accessing the
TransformExampleis currently crashing theRNTesterapp due to missing units in one of the transformers. This PR fixes it by updating the transform value to a valid string.Changelog
[Internal] [Fixed] - Add missing translate units to
RNTesterTransformExampleTest Plan
Transform using a stringsectionScreen.Recording.2022-11-09.at.15.53.00.mov