Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Add dependency on SBO 0.7.0#4622

Closed
dharmit wants to merge 1 commit into
redhat-developer:masterfrom
dharmit:sbo-0.7.0
Closed

Add dependency on SBO 0.7.0#4622
dharmit wants to merge 1 commit into
redhat-developer:masterfrom
dharmit:sbo-0.7.0

Conversation

@dharmit
Copy link
Copy Markdown
Member

@dharmit dharmit commented Apr 15, 2021

What type of PR is this?

/kind dependency-change

What does this PR do / why we need it:
Updates go.mod to use sbo 0.7.0

Which issue(s) this PR fixes:

Fixes #4614

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
I opened this PR because locally make just worked. If the CI gives its blessings, we should be good, IMO.

@dharmit dharmit added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 15, 2021
@openshift-ci-robot openshift-ci-robot added kind/dependency-change and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. labels Apr 15, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 15, 2021
@kadel
Copy link
Copy Markdown
Member

kadel commented Apr 15, 2021

wow. When I tried this I got only errors.
This is good that we can do it. But why adding SBO to the vendor if we don't use it anymore?

@kadel
Copy link
Copy Markdown
Member

kadel commented Apr 15, 2021

wow. When I tried this I got only errors.
This is good that we can do it. But why adding SBO to the vendor if we don't use it anymore?

OH, I know why it suddenly worked for you. It is because we don't use it anywhere :-D :-D.

If you try to use github.com/redhat-developer/service-binding-operator/api/v1alpha1 somewhere you end up with

▶ make
go build -mod=vendor -ldflags="-X github.com/openshift/odo/pkg/version.GITCOMMIT=ffdbf9dd0" cmd/odo/odo.go
# github.com/redhat-developer/service-binding-operator/api/v1alpha1
vendor/github.com/redhat-developer/service-binding-operator/api/v1alpha1/conditions.go:16:44: undefined: v1.Condition
vendor/github.com/redhat-developer/service-binding-operator/api/v1alpha1/conditions.go:17:10: undefined: v1.Condition
vendor/github.com/redhat-developer/service-binding-operator/api/v1alpha1/servicebinding_types.go:118:15: undefined: v1.Condition
vendor/github.com/redhat-developer/service-binding-operator/api/v1alpha1/zz_generated.deepcopy.go:242:17: undefined: v1.Condition
make: *** [Makefile:49: bin] Error 1

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 15, 2021
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 17, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 17, 2021

@dharmit: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit
Copy link
Copy Markdown
Member Author

dharmit commented Apr 21, 2021

Closing this in favour of #4648

/close

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@dharmit: Closed this PR.

Details

In response to this:

Closing this in favour of #4648

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit dharmit deleted the sbo-0.7.0 branch October 21, 2021 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update odo to use newer version of SBO

3 participants