use server side apply

[kadel]

What type of PR is this?

/kind cleanup
/kind code-refactoring

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #4553

** Notes ***
There is a fallback for k8s < v1.16.0. On later versions, it falls back to not using server-side apply. This is ok, as the main reason for using SSA is SBO and SBO won't work on those k8s versions anyway.

I have executed ▶ make test-integration-devfile against ocp 3.11.
Two tests are failing.

Summarizing 2 Failures:

[Fail] odo devfile app command tests Testing URLs for OpenShift specific scenarios [It] it should list, describe and delete the apps 
/home/tomas/Code/Work/odo/tests/helper/helper_run.go:34

[Fail] odo devfile push command tests push with listing the devfile component [It] checks devfile and s2i components together 
/home/tomas/Code/Work/odo/tests/helper/helper_run.go:34

Ran 203 of 208 Specs in 1338.623 seconds
FAIL! -- 201 Passed | 2 Failed | 0 Pending | 5 Skipped

But the same two tests are failing on master as well. So this is not something that was introduced in this PR.

#4678

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

• I have read the test guidelines

How to test changes / Special notes to the reviewer:

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kadel]

error: error creating buildah builder: Error reading signatures: Error downloading signatures for sha256:7157e96d3be123ef879a2c7061271a97b75d58b2669c9afc5ca35cebaa1ba720 in registry.build01.ci.openshift.org/ci/managed-clonerefs: received unexpected HTTP status: 504 Gateway Time-out

/retest

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dharmit]

@kadel, First off, I know that I myself don't entertain the "what about users who modify devfile by hand" discussions. So I'm not asking to tackle the scenario here. I'm just putting my thoughts, and we can very well handle it at a later stage.

With the disclaimer in mind, should something change with regard to our approach for odo service create here: https://github.com/openshift/odo/blob/a920cccb8513da7fc012e699be3c8dda77e3d3ba/pkg/service/service.go#L856-L867

When I wrote that, I simply made sure to ignore the error. But if a user modified the service info (Kubernetes inlined thing) in devfile by hand, odo push won't be able to make changes on the cluster. My understanding/assumption/expectation was the with SSA, it would be possible for odo to handle such changes when doing subsequent odo push.

For example, I'm spinning up an EtcdCluster using below manifest:

- kubernetes:
    inlined: |
      apiVersion: etcd.database.coreos.com/v1beta2
      kind: EtcdCluster
      metadata:
        annotations:
          etcd.database.coreos.com/scope: clusterwide
        name: example
      spec:
        size: 3
        version: 3.2.13
  name: example

I then modified size from size: 3 to size: 1. Should odo push (with support for SSA) be able to scale down the pods for EtcdCluster?

[kadel]

I then modified size from size: 3 to size: 1. Should odo push (with support for SSA) be able to scale down the pods for EtcdCluster?

yes, it should. SSA is not required for this. It should update the existing resources.

[kadel]

/retest

[kadel]

/retest

[kadel]

done, managed to a resolved failing test. It was due to conflicts with #4671

[feloy]

/lgtm

[feloy]

/hold

[dharmit]

Looks good to me.

/hold cancel