chore: initial Qodo configuration - #240
Merged
Merged
Conversation
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/toml-checks.yaml:16` </location>
<code_context>
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: tombi-toml/setup-tombi@v1
+ - name: Validate TOML files
+ run: tombi lint
\ No newline at end of file
</code_context>
<issue_to_address>
Consider pinning the tombi-toml action to a specific commit for security.
Pinning to a commit hash ensures the action's code cannot change unexpectedly, reducing supply chain risks.
</issue_to_address>
## Security Issues
### Issue 1
<location> `.github/workflows/toml-checks.yaml:16` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Member
Author
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Use the glob pattern '/*.toml' instead of '.toml' in the workflow to ensure TOML files in subdirectories are also validated.
- Consider referencing stable version tags (e.g., v5, v1) for actions/checkout and tombi setup rather than commit SHAs to simplify future upgrades.
- Add a fallback or skip logic for Qodo review steps when the JIRA_API_TOKEN is missing to avoid blocking PRs that don’t require Jira integration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Use the glob pattern '**/*.toml' instead of '**.toml' in the workflow to ensure TOML files in subdirectories are also validated.
- Consider referencing stable version tags (e.g., v5, v1) for actions/checkout and tombi setup rather than commit SHAs to simplify future upgrades.
- Add a fallback or skip logic for Qodo review steps when the JIRA_API_TOKEN is missing to avoid blocking PRs that don’t require Jira integration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2 tasks
5 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of the change
Apply changes as in redhat-developer/rhdh-operator#1619
Configuration can be found in their docs:
Which issue(s) does this PR fix or relate to
How to test changes / Special notes to the reviewer
Checklist
Chart.yamlaccording to Semantic Versioning.values.yamland added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes. The pre-commit Workflow will do this automatically for you if needed.pre-commithook.ct lintcommand.Summary by Sourcery
Add initial Qodo PR agent configuration and enforce TOML validation
Enhancements: