chore: initial Qodo configuration - #100
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
General comments:
- Align the rag_repo_list values with the double-quoted style used elsewhere for consistency (e.g., ["repo1","repo2"] instead of ['repo1','repo2']).
- Consider narrowing the workflow’s path filter to target only the intended PR agent config files so you don’t accidentally lint other .toml files in the repo.
- Pin the tombi-toml/setup-tombi action to a more specific version or commit SHA to avoid unexpected breaking changes when the v1 tag is updated.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Align the rag_repo_list values with the double-quoted style used elsewhere for consistency (e.g., ["repo1","repo2"] instead of ['repo1','repo2']).
- Consider narrowing the workflow’s path filter to target only the intended PR agent config files so you don’t accidentally lint other .toml files in the repo.
- Pin the tombi-toml/setup-tombi action to a more specific version or commit SHA to avoid unexpected breaking changes when the v1 tag is updated.
## Individual Comments
### Comment 1
<location> `.pr_agent.toml:38` </location>
<code_context>
+
+[rag_arguments]
+enable_rag=true
+rag_repo_list=['redhat-developer/rhdh','redhat-developer/red-hat-developers-documentation-rhdh','redhat-developer/rhdh-operator','redhat-developer/rhdh-chart']
</code_context>
<issue_to_address>
Consider using double quotes for TOML string arrays for better compatibility.
Double quotes are recommended for TOML string arrays to avoid parser inconsistencies and potential parsing errors.
</issue_to_address>
### Comment 2
<location> `.pr_agent.toml:2` </location>
<code_context>
+[jira]
+jira_api_token = "${{ secrets.JIRA_API_TOKEN }}"
+jira_base_url = "https://issues.redhat.com"
+
</code_context>
<issue_to_address>
Environment variable interpolation may not be supported natively in TOML.
Verify that your tool or workflow can substitute environment variables in TOML files; otherwise, the literal string will be used. Consider other methods for managing secrets if this is not supported.
</issue_to_address>
## Security Issues
### Issue 1
<location> `.github/workflows/toml-checks.yaml:16` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zdrapela
force-pushed
the
qodo-init-z
branch
from
September 11, 2025 13:53
7268047 to
959f953
Compare
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Security Issues
### Issue 1
<location> `.github/workflows/toml-checks.yaml:16` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zdrapela
force-pushed
the
qodo-init-z
branch
from
September 11, 2025 13:57
959f953 to
e037ab1
Compare
Member
Author
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider pinning the actions/checkout and tombi-toml setup steps to official version tags instead of commit SHAs to improve maintainability and clarity.
- It might be helpful to include a schema validation step alongside linting to ensure the .pr_agent.toml adheres to the expected Qodo config structure and catch missing or malformed fields early.
- You could simplify maintenance by merging the TOML validation into an existing CI pipeline or centralizing linting tasks to avoid having a standalone workflow file.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider pinning the actions/checkout and tombi-toml setup steps to official version tags instead of commit SHAs to improve maintainability and clarity.
- It might be helpful to include a schema validation step alongside linting to ensure the .pr_agent.toml adheres to the expected Qodo config structure and catch missing or malformed fields early.
- You could simplify maintenance by merging the TOML validation into an existing CI pipeline or centralizing linting tasks to avoid having a standalone workflow file.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zdrapela
force-pushed
the
qodo-init-z
branch
from
September 11, 2025 14:04
e037ab1 to
cfb4885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply changes as in redhat-developer/rhdh-chart#240
Configuration can be found in their docs:
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Summary by Sourcery
Add initial Qodo PR agent configuration and set up CI checks for TOML validation.
Enhancements:
CI: