chore(update): rename all occurences of janus-idp. to rhdh. prefix

[Fortune-Ndlovu]

Description of the change

chore(update): rename all occurences of janus-idp. to rhdh. prefix

Which issue(s) does this PR fix or relate to

• https://issues.redhat.com/browse/RHDHBUGS-2159

How to test changes / Special notes to the reviewer

Checklist

• For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
• For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes. The pre-commit Workflow will do this automatically for you if needed.
• JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
• Tests pass using the Chart Testing tool and the ct lint command.
• If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

[rhdh-qodo-merge]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 RHDHBUGS-2159 - Partially compliant Compliant requirements: Rename internal Helm template function prefixes from janus-idp to rhdh. Update template function definitions in charts/backstage/templates/_helpers.tpl. Update references in charts/backstage/values.yaml. Update references in charts/backstage/templates/route.yaml. Update references in charts/backstage/README.md and charts/backstage/README.md.gotmpl. Update other documentation/templates shown in diff (e.g., docs/external-db.md, orchestrator template values). Non-compliant requirements: Ensure any other documentation/templates referencing the old prefix are updated accordingly. Requires further human verification: Confirm there are no remaining janus-idp.* includes/defines anywhere else in the repo (full-text search). Validate helm template / ct lint succeeds for all affected charts and the generated README/schema outputs are consistent with the new helpers.

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🔒 No security concerns identified

⚡ Recommended focus areas for review Breaking Change Renaming helper template functions can break downstream/custom templates or user overrides that still call janus-idp.*. Consider providing temporary compatibility aliases (e.g., define janus-idp.hostname that delegates to rhdh.hostname) or clearly documenting this as a breaking change and bumping the chart version appropriately. {{- define "rhdh.hostname" -}} {{- if .Values.global.host -}} {{- .Values.global.host -}} {{- else if .Values.global.clusterRouterBase -}} {{- printf "%s-%s.%s" (include "common.names.fullname" .) .Release.Namespace .Values.global.clusterRouterBase -}} {{- else -}} {{ fail "Unable to generate hostname" }} {{- end -}} {{- end -}} {{/* Returns a secret name for service to service auth */}} {{- define "rhdh.backend-secret-name" -}} {{- if .Values.global.auth.backend.existingSecret -}} {{- .Values.global.auth.backend.existingSecret -}} {{- else -}} {{- printf "%s-auth" .Release.Name -}} {{- end -}} {{- end -}} {{/* Sets the secretKeyRef name for Backstage to the PostgreSQL existing secret if it present */}} {{- define "rhdh.postgresql.secretName" -}} {{- if ((((.Values).global).postgresql).auth).existingSecret -}} {{- .Values.global.postgresql.auth.existingSecret -}} {{- else if .Values.postgresql.auth.existingSecret -}} {{- .Values.postgresql.auth.existingSecret -}} Template in Schema The JSON schema default strings embed Helm template includes (e.g., {{ include "rhdh.hostname" . }}). Ensure the schema generation/validation tooling expects these templates as plain strings and that all embedded helper names were updated consistently (including $ vs . usage) to avoid mismatches between schema defaults and rendered chart behavior. "baseUrl": "https://{{- include \"rhdh.hostname\" . }}" }, "auth": { "providers": {} }, "backend": { "auth": { "externalAccess": [ { "options": { "secret": "${BACKEND_SECRET}", "subject": "legacy-default-config" }, "type": "legacy" } ] }, "baseUrl": "https://{{- include \"rhdh.hostname\" . }}", "cors": { "origin": "https://{{- include \"rhdh.hostname\" . }}" }, "database": { "connection": { "password": "${POSTGRESQL_ADMIN_PASSWORD}", "user": "postgres" } } } }, "examples": [ { "app": { "baseUrl": "https://somedomain.tld" } } ], "title": "Generates ConfigMap and configures it in the Backstage pods", "type": [ "object", "string" ] }, "args": { "default": [ "--config", "dynamic-plugins-root/app-config.dynamic-plugins.yaml" ], "items": { "type": "string" }, "title": "Backstage container command arguments", "type": "array" }, "autoscaling": { "additionalProperties": false, "properties": { "enabled": { "default": false, "description": "Enable autoscaling", "title": "Backstage Autoscaling", "type": "boolean" }, "maxReplicas": { "default": 100, "title": "Maximum number of Backstage pod replicas that the autoscaler is allowed to scale up to", "type": "integer" }, "minReplicas": { "default": 1, "title": "Minimum number of Backstage pod replicas that the autoscaler is allowed to scale down to", "type": "integer" }, "targetCPUUtilizationPercentage": { "default": 80, "title": "Percentage of CPU that each Backstage pod should be using on average before the autoscaler decides to scale", "type": "integer" }, "targetMemoryUtilizationPercentage": { "title": "Percentage of memory that each Backstage pod should be using on average before the autoscaler decides to scale", "type": "integer" } }, "title": "Autoscaling parameters", "type": "object" }, "command": { "default": [], "items": { "type": "string" }, "title": "Backstage container command", "type": "array" }, "containerPorts": { "additionalProperties": false, "properties": { "backend": { "default": 7007, "title": "Backstage backend port.", "type": "integer" } }, "title": "Container ports on the Deployment", "type": "object" }, "containerSecurityContext": { "description": "SecurityContext holds security configuration that will be applied to a container. Some fields are present in both SecurityContext and PodSecurityContext. When both are set, the values in SecurityContext take precedence.", "properties": { "allowPrivilegeEscalation": { "description": "AllowPrivilegeEscalation controls whether a process can gain more privileges than its parent process. This bool directly controls if the no_new_privs flag will be set on the container process. AllowPrivilegeEscalation is true always when the container is: 1) run as Privileged 2) has CAP_SYS_ADMIN Note that this field cannot be set when spec.os.name is windows.", "type": "boolean" }, "appArmorProfile": { "description": "AppArmorProfile defines a pod or container's AppArmor settings.", "properties": { "localhostProfile": { "description": "localhostProfile indicates a profile loaded on the node that should be used. The profile must be preconfigured on the node to work. Must match the loaded name of the profile. Must be set if and only if type is \"Localhost\".", "type": "string" }, "type": { "description": "type indicates which kind of AppArmor profile will be applied. Valid options are:\n Localhost - a profile pre-loaded on the node.\n RuntimeDefault - the container runtime's default profile.\n Unconfined - no AppArmor enforcement.", "type": "string" } }, "required": [ "type" ], "type": "object", "x-kubernetes-unions": [ { "discriminator": "type", "fields-to-discriminateBy": { "localhostProfile": "LocalhostProfile" } } ] }, "capabilities": { "description": "Adds and removes POSIX capabilities from running containers.", "properties": { "add": { "description": "Added capabilities", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "drop": { "description": "Removed capabilities", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" } }, "type": "object" }, "privileged": { "description": "Run container in privileged mode. Processes in privileged containers are essentially equivalent to root on the host. Defaults to false. Note that this field cannot be set when spec.os.name is windows.", "type": "boolean" }, "procMount": { "description": "procMount denotes the type of proc mount to use for the containers. The default value is Default which uses the container runtime defaults for readonly paths and masked paths. This requires the ProcMountType feature flag to be enabled. Note that this field cannot be set when spec.os.name is windows.", "type": "string" }, "readOnlyRootFilesystem": { "description": "Whether this container has a read-only root filesystem. Default is false. Note that this field cannot be set when spec.os.name is windows.", "type": "boolean" }, "runAsGroup": { "description": "The GID to run the entrypoint of the container process. Uses runtime default if unset. May also be set in PodSecurityContext. If set in both SecurityContext and PodSecurityContext, the value specified in SecurityContext takes precedence. Note that this field cannot be set when spec.os.name is windows.", "type": "integer" }, "runAsNonRoot": { "description": "Indicates that the container must run as a non-root user. If true, the Kubelet will validate the image at runtime to ensure that it does not run as UID 0 (root) and fail to start the container if it does. If unset or false, no such validation will be performed. May also be set in PodSecurityContext. If set in both SecurityContext and PodSecurityContext, the value specified in SecurityContext takes precedence.", "type": "boolean" }, "runAsUser": { "description": "The UID to run the entrypoint of the container process. Defaults to user specified in image metadata if unspecified. May also be set in PodSecurityContext. If set in both SecurityContext and PodSecurityContext, the value specified in SecurityContext takes precedence. Note that this field cannot be set when spec.os.name is windows.", "type": "integer" }, "seLinuxOptions": { "description": "SELinuxOptions are the labels to be applied to the container", "properties": { "level": { "description": "Level is SELinux level label that applies to the container.", "type": "string" }, "role": { "description": "Role is a SELinux role label that applies to the container.", "type": "string" }, "type": { "description": "Type is a SELinux type label that applies to the container.", "type": "string" }, "user": { "description": "User is a SELinux user label that applies to the container.", "type": "string" } }, "type": "object" }, "seccompProfile": { "description": "SeccompProfile defines a pod/container's seccomp profile settings. Only one profile source may be set.", "properties": { "localhostProfile": { "description": "localhostProfile indicates a profile defined in a file on the node should be used. The profile must be preconfigured on the node to work. Must be a descending path, relative to the kubelet's configured seccomp profile location. Must be set if type is \"Localhost\". Must NOT be set for any other type.", "type": "string" }, "type": { "description": "type indicates which kind of seccomp profile will be applied. Valid options are:\n\nLocalhost - a profile defined in a file on the node should be used. RuntimeDefault - the container runtime default profile should be used. Unconfined - no profile should be applied.", "type": "string" } }, "required": [ "type" ], "type": "object", "x-kubernetes-unions": [ { "discriminator": "type", "fields-to-discriminateBy": { "localhostProfile": "LocalhostProfile" } } ] }, "windowsOptions": { "description": "WindowsSecurityContextOptions contain Windows-specific options and credentials.", "properties": { "gmsaCredentialSpec": { "description": "GMSACredentialSpec is where the GMSA admission webhook (https://github.com/kubernetes-sigs/windows-gmsa) inlines the contents of the GMSA credential spec named by the GMSACredentialSpecName field.", "type": "string" }, "gmsaCredentialSpecName": { "description": "GMSACredentialSpecName is the name of the GMSA credential spec to use.", "type": "string" }, "hostProcess": { "description": "HostProcess determines if a container should be run as a 'Host Process' container. All of a Pod's containers must have the same effective HostProcess value (it is not allowed to have a mix of HostProcess containers and non-HostProcess containers). In addition, if HostProcess is true then HostNetwork must also be set to true.", "type": "boolean" }, "runAsUserName": { "description": "The UserName in Windows to run the entrypoint of the container process. Defaults to the user specified in image metadata if unspecified. May also be set in PodSecurityContext. If set in both SecurityContext and PodSecurityContext, the value specified in SecurityContext takes precedence.", "type": "string" } }, "type": "object" } }, "type": "object" }, "extraAppConfig": { "default": [], "items": { "additionalProperties": false, "properties": { "configMapRef": { "type": "string" }, "filename": { "type": "string" } }, "type": "object" }, "title": "Extra app configuration files to inline into command arguments", "type": "array" }, "extraContainers": { "default": [], "items": { "description": "A single application container that you want to run within a pod.", "properties": { "args": { "description": "Arguments to the entrypoint. The container image's CMD is used if this is not provided. Variable references $(VAR_NAME) are expanded using the container's environment. If a variable cannot be resolved, the reference in the input string will be unchanged. Double $$ are reduced to a single $, which allows for escaping the $(VAR_NAME) syntax: i.e. \"$$(VAR_NAME)\" will produce the string literal \"$(VAR_NAME)\". Escaped references will never be expanded, regardless of whether the variable exists or not. Cannot be updated. More info: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#running-a-command-in-a-shell", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "command": { "description": "Entrypoint array. Not executed within a shell. The container image's ENTRYPOINT is used if this is not provided. Variable references $(VAR_NAME) are expanded using the container's environment. If a variable cannot be resolved, the reference in the input string will be unchanged. Double $$ are reduced to a single $, which allows for escaping the $(VAR_NAME) syntax: i.e. \"$$(VAR_NAME)\" will produce the string literal \"$(VAR_NAME)\". Escaped references will never be expanded, regardless of whether the variable exists or not. Cannot be updated. More info: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#running-a-command-in-a-shell", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "env": { "description": "List of environment variables to set in the container. Cannot be updated.", "items": { "description": "EnvVar represents an environment variable present in a Container.", "properties": { "name": { "description": "Name of the environment variable. Must be a C_IDENTIFIER.", "type": "string" }, "value": { "description": "Variable references $(VAR_NAME) are expanded using the previously defined environment variables in the container and any service environment variables. If a variable cannot be resolved, the reference in the input string will be unchanged. Double $$ are reduced to a single $, which allows for escaping the $(VAR_NAME) syntax: i.e. \"$$(VAR_NAME)\" will produce the string literal \"$(VAR_NAME)\". Escaped references will never be expanded, regardless of whether the variable exists or not. Defaults to \"\".", "type": "string" }, "valueFrom": { "description": "EnvVarSource represents a source for the value of an EnvVar.", "properties": { "configMapKeyRef": { "description": "Selects a key from a ConfigMap.", "properties": { "key": { "description": "The key to select.", "type": "string" }, "name": { "description": "Name of the referent. This field is effectively required, but due to backwards compatibility is allowed to be empty. Instances of this type with an empty value here are almost certainly wrong. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names", "type": "string" }, "optional": { "description": "Specify whether the ConfigMap or its key must be defined", "type": "boolean" } }, "required": [ "key" ], "type": "object", "x-kubernetes-map-type": "atomic" }, "fieldRef": { "description": "ObjectFieldSelector selects an APIVersioned field of an object.", "properties": { "apiVersion": { "description": "Version of the schema the FieldPath is written in terms of, defaults to \"v1\".", "type": "string" }, "fieldPath": { "description": "Path of the field to select in the specified API version.", "type": "string" } }, "required": [ "fieldPath" ], "type": "object", "x-kubernetes-map-type": "atomic" }, "resourceFieldRef": { "description": "ResourceFieldSelector represents container resources (cpu, memory) and their output format", "properties": { "containerName": { "description": "Container name: required for volumes, optional for env vars", "type": "string" }, "divisor": { "oneOf": [ { "type": "string" }, { "type": "number" } ] }, "resource": { "description": "Required: resource to select", "type": "string" } }, "required": [ "resource" ], "type": "object", "x-kubernetes-map-type": "atomic" }, "secretKeyRef": { "description": "SecretKeySelector selects a key of a Secret.", "properties": { "key": { "description": "The key of the secret to select from. Must be a valid secret key.", "type": "string" }, "name": { "description": "Name of the referent. This field is effectively required, but due to backwards compatibility is allowed to be empty. Instances of this type with an empty value here are almost certainly wrong. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names", "type": "string" }, "optional": { "description": "Specify whether the Secret or its key must be defined", "type": "boolean" } }, "required": [ "key" ], "type": "object", "x-kubernetes-map-type": "atomic" } }, "type": "object" } }, "required": [ "name" ], "type": "object" }, "type": "array", "x-kubernetes-list-map-keys": [ "name" ], "x-kubernetes-list-type": "map", "x-kubernetes-patch-merge-key": "name", "x-kubernetes-patch-strategy": "merge" }, "envFrom": { "description": "List of sources to populate environment variables in the container. The keys defined within a source must be a C_IDENTIFIER. All invalid keys will be reported as an event when the container is starting. When a key exists in multiple sources, the value associated with the last source will take precedence. Values defined by an Env with a duplicate key will take precedence. Cannot be updated.", "items": { "description": "EnvFromSource represents the source of a set of ConfigMaps or Secrets", "properties": { "configMapRef": { "description": "ConfigMapEnvSource selects a ConfigMap to populate the environment variables with.\n\nThe contents of the target ConfigMap's Data field will represent the key-value pairs as environment variables.", "properties": { "name": { "description": "Name of the referent. This field is effectively required, but due to backwards compatibility is allowed to be empty. Instances of this type with an empty value here are almost certainly wrong. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names", "type": "string" }, "optional": { "description": "Specify whether the ConfigMap must be defined", "type": "boolean" } }, "type": "object" }, "prefix": { "description": "Optional text to prepend to the name of each environment variable. Must be a C_IDENTIFIER.", "type": "string" }, "secretRef": { "description": "SecretEnvSource selects a Secret to populate the environment variables with.\n\nThe contents of the target Secret's Data field will represent the key-value pairs as environment variables.", "properties": { "name": { "description": "Name of the referent. This field is effectively required, but due to backwards compatibility is allowed to be empty. Instances of this type with an empty value here are almost certainly wrong. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names", "type": "string" }, "optional": { "description": "Specify whether the Secret must be defined", "type": "boolean" } }, "type": "object" } }, "type": "object" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "image": { "description": "Container image name. More info: https://kubernetes.io/docs/concepts/containers/images This field is optional to allow higher level config management to default or override container images in workload controllers like Deployments and StatefulSets.", "type": "string" }, "imagePullPolicy": { "description": "Image pull policy. One of Always, Never, IfNotPresent. Defaults to Always if :latest tag is specified, or IfNotPresent otherwise. Cannot be updated. More info: https://kubernetes.io/docs/concepts/containers/images#updating-images", "type": "string" }, "lifecycle": { "description": "Lifecycle describes actions that the management system should take in response to container lifecycle events. For the PostStart and PreStop lifecycle handlers, management of the container blocks until the action is complete, unless the container process fails, in which case the handler is aborted.", "properties": { "postStart": { "description": "LifecycleHandler defines a specific action that should be taken in a lifecycle hook. One and only one of the fields, except TCPSocket must be specified.", "properties": { "exec": { "description": "ExecAction describes a \"run in container\" action.", "properties": { "command": { "description": "Command is the command line to execute inside the container, the working directory for the command is root ('/') in the container's filesystem. The command is simply exec'd, it is not run inside a shell, so traditional shell instructions ('|', etc) won't work. To use a shell, you need to explicitly call out to that shell. Exit status of 0 is treated as live/healthy and non-zero is unhealthy.", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" } }, "type": "object" }, "httpGet": { "description": "HTTPGetAction describes an action based on HTTP Get requests.", "properties": { "host": { "description": "Host name to connect to, defaults to the pod IP. You probably want to set \"Host\" in httpHeaders instead.", "type": "string" }, "httpHeaders": { "description": "Custom headers to set in the request. HTTP allows repeated headers.", "items": { "description": "HTTPHeader describes a custom header to be used in HTTP probes", "properties": { "name": { "description": "The header field name. This will be canonicalized upon output, so case-variant names will be understood as the same header.", "type": "string" }, "value": { "description": "The header field value", "type": "string" } }, "required": [ "name", "value" ], "type": "object" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "path": { "description": "Path to access on the HTTP server.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] }, "scheme": { "description": "Scheme to use for connecting to the host. Defaults to HTTP.", "type": "string" } }, "required": [ "port" ], "type": "object" }, "sleep": { "description": "SleepAction describes a \"sleep\" action.", "properties": { "seconds": { "description": "Seconds is the number of seconds to sleep.", "type": "integer" } }, "required": [ "seconds" ], "type": "object" }, "tcpSocket": { "description": "TCPSocketAction describes an action based on opening a socket", "properties": { "host": { "description": "Optional: Host name to connect to, defaults to the pod IP.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] } }, "required": [ "port" ], "type": "object" } }, "type": "object" }, "preStop": { "description": "LifecycleHandler defines a specific action that should be taken in a lifecycle hook. One and only one of the fields, except TCPSocket must be specified.", "properties": { "exec": { "description": "ExecAction describes a \"run in container\" action.", "properties": { "command": { "description": "Command is the command line to execute inside the container, the working directory for the command is root ('/') in the container's filesystem. The command is simply exec'd, it is not run inside a shell, so traditional shell instructions ('|', etc) won't work. To use a shell, you need to explicitly call out to that shell. Exit status of 0 is treated as live/healthy and non-zero is unhealthy.", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" } }, "type": "object" }, "httpGet": { "description": "HTTPGetAction describes an action based on HTTP Get requests.", "properties": { "host": { "description": "Host name to connect to, defaults to the pod IP. You probably want to set \"Host\" in httpHeaders instead.", "type": "string" }, "httpHeaders": { "description": "Custom headers to set in the request. HTTP allows repeated headers.", "items": { "description": "HTTPHeader describes a custom header to be used in HTTP probes", "properties": { "name": { "description": "The header field name. This will be canonicalized upon output, so case-variant names will be understood as the same header.", "type": "string" }, "value": { "description": "The header field value", "type": "string" } }, "required": [ "name", "value" ], "type": "object" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "path": { "description": "Path to access on the HTTP server.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] }, "scheme": { "description": "Scheme to use for connecting to the host. Defaults to HTTP.", "type": "string" } }, "required": [ "port" ], "type": "object" }, "sleep": { "description": "SleepAction describes a \"sleep\" action.", "properties": { "seconds": { "description": "Seconds is the number of seconds to sleep.", "type": "integer" } }, "required": [ "seconds" ], "type": "object" }, "tcpSocket": { "description": "TCPSocketAction describes an action based on opening a socket", "properties": { "host": { "description": "Optional: Host name to connect to, defaults to the pod IP.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] } }, "required": [ "port" ], "type": "object" } }, "type": "object" }, "stopSignal": { "description": "StopSignal defines which signal will be sent to a container when it is being stopped. If not specified, the default is defined by the container runtime in use. StopSignal can only be set for Pods with a non-empty .spec.os.name", "type": "string" } }, "type": "object" }, "livenessProbe": { "description": "Probe describes a health check to be performed against a container to determine whether it is alive or ready to receive traffic.", "properties": { "exec": { "description": "ExecAction describes a \"run in container\" action.", "properties": { "command": { "description": "Command is the command line to execute inside the container, the working directory for the command is root ('/') in the container's filesystem. The command is simply exec'd, it is not run inside a shell, so traditional shell instructions ('|', etc) won't work. To use a shell, you need to explicitly call out to that shell. Exit status of 0 is treated as live/healthy and non-zero is unhealthy.", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" } }, "type": "object" }, "failureThreshold": { "description": "Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.", "type": "integer" }, "grpc": { "description": "GRPCAction specifies an action involving a GRPC service.", "properties": { "port": { "description": "Port number of the gRPC service. Number must be in the range 1 to 65535.", "type": "integer" }, "service": { "description": "Service is the name of the service to place in the gRPC HealthCheckRequest (see https://github.com/grpc/grpc/blob/master/doc/health-checking.md).\n\nIf this is not specified, the default behavior is defined by gRPC.", "type": "string" } }, "required": [ "port" ], "type": "object" }, "httpGet": { "description": "HTTPGetAction describes an action based on HTTP Get requests.", "properties": { "host": { "description": "Host name to connect to, defaults to the pod IP. You probably want to set \"Host\" in httpHeaders instead.", "type": "string" }, "httpHeaders": { "description": "Custom headers to set in the request. HTTP allows repeated headers.", "items": { "description": "HTTPHeader describes a custom header to be used in HTTP probes", "properties": { "name": { "description": "The header field name. This will be canonicalized upon output, so case-variant names will be understood as the same header.", "type": "string" }, "value": { "description": "The header field value", "type": "string" } }, "required": [ "name", "value" ], "type": "object" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "path": { "description": "Path to access on the HTTP server.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] }, "scheme": { "description": "Scheme to use for connecting to the host. Defaults to HTTP.", "type": "string" } }, "required": [ "port" ], "type": "object" }, "initialDelaySeconds": { "description": "Number of seconds after the container has started before liveness probes are initiated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", "type": "integer" }, "periodSeconds": { "description": "How often (in seconds) to perform the probe. Default to 10 seconds. Minimum value is 1.", "type": "integer" }, "successThreshold": { "description": "Minimum consecutive successes for the probe to be considered successful after having failed. Defaults to 1. Must be 1 for liveness and startup. Minimum value is 1.", "type": "integer" }, "tcpSocket": { "description": "TCPSocketAction describes an action based on opening a socket", "properties": { "host": { "description": "Optional: Host name to connect to, defaults to the pod IP.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] } }, "required": [ "port" ], "type": "object" }, "terminationGracePeriodSeconds": { "description": "Optional duration in seconds the pod needs to terminate gracefully upon probe failure. The grace period is the duration in seconds after the processes running in the pod are sent a termination signal and the time when the processes are forcibly halted with a kill signal. Set this value longer than the expected cleanup time for your process. If this value is nil, the pod's terminationGracePeriodSeconds will be used. Otherwise, this value overrides the value provided by the pod spec. Value must be non-negative integer. The value zero indicates stop immediately via the kill signal (no opportunity to shut down). This is a beta field and requires enabling ProbeTerminationGracePeriod feature gate. Minimum value is 1. spec.terminationGracePeriodSeconds is used if unset.", "type": "integer" }, "timeoutSeconds": { "description": "Number of seconds after which the probe times out. Defaults to 1 second. Minimum value is 1. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", "type": "integer" } }, "type": "object" }, "name": { "description": "Name of the container specified as a DNS_LABEL. Each container in a pod must have a unique name (DNS_LABEL). Cannot be updated.", "type": "string" }, "ports": { "description": "List of ports to expose from the container. Not specifying a port here DOES NOT prevent that port from being exposed. Any port which is listening on the default \"0.0.0.0\" address inside a container will be accessible from the network. Modifying this array with strategic merge patch may corrupt the data. For more information See https://github.com/kubernetes/kubernetes/issues/108255. Cannot be updated.", "items": { "description": "ContainerPort represents a network port in a single container.", "properties": { "containerPort": { "description": "Number of port to expose on the pod's IP address. This must be a valid port number, 0 < x < 65536.", "type": "integer" }, "hostIP": { "description": "What host IP to bind the external port to.", "type": "string" }, "hostPort": { "description": "Number of port to expose on the host. If specified, this must be a valid port number, 0 < x < 65536. If HostNetwork is specified, this must match ContainerPort. Most containers do not need this.", "type": "integer" }, "name": { "description": "If specified, this must be an IANA_SVC_NAME and unique within the pod. Each named port in a pod must have a unique name. Name for the port that can be referred to by services.", "type": "string" }, "protocol": { "description": "Protocol for port. Must be UDP, TCP, or SCTP. Defaults to \"TCP\".", "type": "string" } }, "required": [ "containerPort" ], "type": "object" }, "type": "array", "x-kubernetes-list-map-keys": [ "containerPort", "protocol" ], "x-kubernetes-list-type": "map", "x-kubernetes-patch-merge-key": "containerPort", "x-kubernetes-patch-strategy": "merge" }, "readinessProbe": { "description": "Probe describes a health check to be performed against a container to determine whether it is alive or ready to receive traffic.", "properties": { "exec": { "description": "ExecAction describes a \"run in container\" action.", "properties": { "command": { "description": "Command is the command line to execute inside the container, the working directory for the command is root ('/') in the container's filesystem. The command is simply exec'd, it is not run inside a shell, so traditional shell instructions ('|', etc) won't work. To use a shell, you need to explicitly call out to that shell. Exit status of 0 is treated as live/healthy and non-zero is unhealthy.", "items": { "type": "string" }, "type": "array", "x-kubernetes-list-type": "atomic" } }, "type": "object" }, "failureThreshold": { "description": "Minimum consecutive failures for the probe to be considered failed after having succeeded. Defaults to 3. Minimum value is 1.", "type": "integer" }, "grpc": { "description": "GRPCAction specifies an action involving a GRPC service.", "properties": { "port": { "description": "Port number of the gRPC service. Number must be in the range 1 to 65535.", "type": "integer" }, "service": { "description": "Service is the name of the service to place in the gRPC HealthCheckRequest (see https://github.com/grpc/grpc/blob/master/doc/health-checking.md).\n\nIf this is not specified, the default behavior is defined by gRPC.", "type": "string" } }, "required": [ "port" ], "type": "object" }, "httpGet": { "description": "HTTPGetAction describes an action based on HTTP Get requests.", "properties": { "host": { "description": "Host name to connect to, defaults to the pod IP. You probably want to set \"Host\" in httpHeaders instead.", "type": "string" }, "httpHeaders": { "description": "Custom headers to set in the request. HTTP allows repeated headers.", "items": { "description": "HTTPHeader describes a custom header to be used in HTTP probes", "properties": { "name": { "description": "The header field name. This will be canonicalized upon output, so case-variant names will be understood as the same header.", "type": "string" }, "value": { "description": "The header field value", "type": "string" } }, "required": [ "name", "value" ], "type": "object" }, "type": "array", "x-kubernetes-list-type": "atomic" }, "path": { "description": "Path to access on the HTTP server.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] }, "scheme": { "description": "Scheme to use for connecting to the host. Defaults to HTTP.", "type": "string" } }, "required": [ "port" ], "type": "object" }, "initialDelaySeconds": { "description": "Number of seconds after the container has started before liveness probes are initiated. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", "type": "integer" }, "periodSeconds": { "description": "How often (in seconds) to perform the probe. Default to 10 seconds. Minimum value is 1.", "type": "integer" }, "successThreshold": { "description": "Minimum consecutive successes for the probe to be considered successful after having failed. Defaults to 1. Must be 1 for liveness and startup. Minimum value is 1.", "type": "integer" }, "tcpSocket": { "description": "TCPSocketAction describes an action based on opening a socket", "properties": { "host": { "description": "Optional: Host name to connect to, defaults to the pod IP.", "type": "string" }, "port": { "oneOf": [ { "type": "string" }, { "type": "integer" } ] } }, "required": [ "port" ], "type": "object" }, "terminationGracePeriodSeconds": { "description": "Optional duration in seconds the pod needs to terminate gracefully upon probe failure. The grace period is the duration in seconds after the processes running in the pod are sent a termination signal and the time when the processes are forcibly halted with a kill signal. Set this value longer than the expected cleanup time for your process. If this value is nil, the pod's terminationGracePeriodSeconds will be used. Otherwise, this value overrides the value provided by the pod spec. Value must be non-negative integer. The value zero indicates stop immediately via the kill signal (no opportunity to shut down). This is a beta field and requires enabling ProbeTerminationGracePeriod feature gate. Minimum value is 1. spec.terminationGracePeriodSeconds is used if unset.", "type": "integer" }, "timeoutSeconds": { "description": "Number of seconds after which the probe times out. Defaults to 1 second. Minimum value is 1. More info: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes", "type": "integer" } }, "type": "object" }, "resizePolicy": { "description": "Resources resize policy for the container.", "items": { "description": "ContainerResizePolicy represents resource resize policy for the container.", "properties": { "resourceName": { "description": "Name of the resource to which this resource resize policy applies. Supported values: cpu, memory.", "type": "string" }, "restartPolicy": { "description": "Restart policy to apply when specified resource is resized. If not specified, it defaults to NotRequired.", "type": "string" ...

[rhdh-qodo-merge]

PR Type

(Describe updated until commit 1f8cf9c)

Enhancement

---

Description

• Rename all janus-idp prefix occurrences to rhdh across Helm charts and documentation

• Update container image references from janus-idp/backstage-showcase to rhdh-community/rhdh:next

• Remove deprecated GitHub issue workflow and update issue template to redirect to JIRA

• Bump chart versions for backstage (5.0.0 → 5.0.1), orchestrator-software-templates (0.2.0 → 0.2.1), and orchestrator-software-templates-infra (0.3.0 → 0.3.1)

• Update copyright notice from "Janus-IDP Authors" to "RHDH Authors" and fix documentation links to point to redhat-developer repositories

---

File Walkthrough

	Relevant files
Enhancement	2 files _helpers.tpl Rename template helper definitions from janus-idp to rhdh +3/-3      route.yaml Update route template helper reference to rhdh                      +1/-1
Configuration changes	9 files config.yml Update issue template to redirect to JIRA instead of Slack +3/-3      on-new-issue.yaml Remove deprecated GitHub issue automation workflow              +0/-22    Chart.yaml Bump backstage chart version to 5.0.1                                        +1/-1      values.schema.json Update schema with rhdh template references and image        +5/-5      values.schema.tmpl.json Update image repository to rhdh-community/rhdh:next            +2/-2      values.yaml Update values with rhdh references and image configuration +8/-8      Chart.yaml Bump orchestrator-software-templates-infra chart to 0.3.1 +1/-1      Chart.yaml Bump orchestrator-software-templates chart to 0.2.1            +1/-1      orchestrator-templates-values.yaml.template Update template helper references to rhdh                                +2/-2
Documentation	7 files LICENSE Update copyright from Janus-IDP to RHDH Authors                    +1/-1      README.md Update documentation with rhdh references and image changes +11/-13  README.md.gotmpl Update template documentation with rhdh references              +7/-9      README.md Update version badge and installation instructions              +2/-2      GitopsOperator.md Update namespace references from janus to rhdh                      +5/-5      README.md Update version badge and installation instructions              +2/-2      external-db.md Update documentation links to rhdh-operator repository      +4/-4

---

[rhdh-qodo-merge]

PR Code Suggestions ✨

Latest suggestions up to 1f8cf9c

Category	Suggestion	Impact
Incremental [*]	Align documented namespaces consistently Align the namespace in the installation command (rhdh-argocd) with the one in the removal instructions (rhdh-gitops) for consistency. charts/orchestrator-software-templates-infra/docs/GitopsOperator.md [15] -helm upgrade --install argocd . -f values.yaml -n rhdh-argocd --create-namespace +helm upgrade --install argocd . -f values.yaml -n rhdh-gitops --create-namespace Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a critical inconsistency in the documentation between the installation and removal commands, which could lead to user errors and orphaned resources.	Medium
Update

---

Previous suggestions

Suggestions up to commit c354a0c

Category	Suggestion	Impact
High-level	This breaking change requires a major version bump The renaming of Helm template functions is a breaking change. A major version bump in the chart's Chart.yaml is required as per semantic versioning to prevent breaking user upgrades. Examples: charts/backstage/templates/_helpers.tpl [4-12] {{- define "rhdh.hostname" -}} {{- if .Values.global.host -}} {{- .Values.global.host -}} {{- else if .Values.global.clusterRouterBase -}} {{- printf "%s-%s.%s" (include "common.names.fullname" .) .Release.Namespace .Values.global.clusterRouterBase -}} {{- else -}} {{ fail "Unable to generate hostname" }} {{- end -}} {{- end -}} charts/backstage/templates/_helpers.tpl [17-23] {{- define "rhdh.backend-secret-name" -}} {{- if .Values.global.auth.backend.existingSecret -}} {{- .Values.global.auth.backend.existingSecret -}} {{- else -}} {{- printf "%s-auth" .Release.Name -}} {{- end -}} {{- end -}} Solution Walkthrough: Before: # charts/backstage/templates/_helpers.tpl {{- define "janus-idp.hostname" -}} ... {{- end -}} # charts/backstage/values.yaml upstream: backstage: appConfig: app: baseUrl: 'https://{{- include "janus-idp.hostname" . }}' # charts/backstage/Chart.yaml (not in PR) # version: x.y.z (unchanged) After: # charts/backstage/templates/_helpers.tpl {{- define "rhdh.hostname" -}} ... {{- end -}} # charts/backstage/values.yaml upstream: backstage: appConfig: app: baseUrl: 'https://{{- include "rhdh.hostname" . }}' # charts/backstage/Chart.yaml (suggested change) # version: (x+1).0.0 (major version bumped) Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies that renaming Helm template functions is a breaking API change, and points out the critical and missing major version bump in Chart.yaml to adhere to semantic versioning.	High
General	Add whitespace control to template Add whitespace control (-) to the Helm include call for rhdh.backend-secret-name to ensure consistent and clean YAML output. docs/external-db.md [81] -name: '{{ include "rhdh.backend-secret-name" $ }}' +name: '{{- include "rhdh.backend-secret-name" $ }}' Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies an inconsistency in Helm template whitespace control, which is a good practice to fix for cleaner output, though it has a minor impact.	Low

[rm3l]

There are still quite a few occurrences of janus. Could you please take a look at those while you're at it? Thanks.

.github/ISSUE_TEMPLATE/config.yml:  - name: ❓ Janus IDP Community Slack
.github/ISSUE_TEMPLATE/config.yml:    url: https://join.slack.com/t/janus-idp/shared_invite/zt-1pxtehxom-fCFtF9rRe3vFqUiFFeAkmg
.github/workflows/on-new-issue.yaml:    # https://github.com/janus-idp/.github/blob/main/.github/workflows/add-to-project.yaml
.github/workflows/on-new-issue.yaml:    uses: janus-idp/.github/.github/workflows/add-to-project.yaml@main
LICENSE:Copyright 2022 The Janus-IDP Authors
charts/backstage/README.md:Note: this repo replaces https://github.com/janus-idp/helm-backstage, which has been deprecated in Feb 2024.
charts/backstage/README.md:| global.dynamic.includes[0] | List of dynamic plugins included inside the `janus-idp/backstage-showcase` container image, some of which are disabled by default. This file ONLY works with the `janus-idp/backstage-showcase` container image. | string | `"dynamic-plugins.default.yaml"` |
charts/backstage/README.md:| upstream.backstage.initContainers[0].image | Image used by the initContainer to install dynamic plugins into the `dynamic-plugins-root` volume mount. It could be replaced by a custom image based on this one. | string | `quay.io/janus-idp/backstage-showcase:latest` |
charts/backstage/README.md:1. Uses [janus-idp/backstage-showcase](https://github.com/janus-idp/backstage-showcase/) that pre-loads a lot of useful plugins and features
charts/backstage/README.md:For additional instance features please consult the [documentation for `janus-idp/backstage-showcase`](https://github.com/janus-idp/backstage-showcase/tree/main/showcase-docs).
charts/backstage/README.md:This charts defaults to using the [latest Janus-IDP Backstage Showcase image](https://quay.io/janus-idp/backstage-showcase:latest) that is OpenShift compatible:
charts/backstage/README.md:quay.io/janus-idp/backstage-showcase:latest
charts/backstage/README.md.gotmpl:Note: this repo replaces https://github.com/janus-idp/helm-backstage, which has been deprecated in Feb 2024.
charts/backstage/README.md.gotmpl:1. Uses [janus-idp/backstage-showcase](https://github.com/janus-idp/backstage-showcase/) that pre-loads a lot of useful plugins and features
charts/backstage/README.md.gotmpl:For additional instance features please consult the [documentation for `janus-idp/backstage-showcase`](https://github.com/janus-idp/backstage-showcase/tree/main/showcase-docs).
charts/backstage/README.md.gotmpl:This charts defaults to using the [latest Janus-IDP Backstage Showcase image](https://quay.io/janus-idp/backstage-showcase:latest) that is OpenShift compatible:
charts/backstage/README.md.gotmpl:quay.io/janus-idp/backstage-showcase:latest
charts/backstage/values.schema.tmpl.json:                        "repository": "janus-idp/redhat-backstage-build",
charts/backstage/values.yaml:      # -- List of dynamic plugins included inside the `janus-idp/backstage-showcase` container image, some of which are disabled by default.
charts/backstage/values.yaml:      # This file ONLY works with the `janus-idp/backstage-showcase` container image.
charts/backstage/values.yaml:        # @default -- `quay.io/janus-idp/backstage-showcase:latest`
charts/orchestrator-software-templates-infra/docs/GitopsOperator.md:>The openshift-gitops subchart is adapted from the [gitops operator Helm Chart provided in the redhat-gpte-devopsautomation/janus-idp-bootstrap project](https://github.com/redhat-gpte-devopsautomation/janus-idp-bootstrap/tree/main/charts/gitops-operator). Orchestrator-software-templates-infra will act as a wrapper Chart for that unreleased Chart, providing some of its functionality and adapting it for orchestrator needs and applying specific configuration.
charts/orchestrator-software-templates-infra/docs/GitopsOperator.md:helm upgrade --install argocd . -f values.yaml -n janus-argocd --create-namespace
charts/orchestrator-software-templates-infra/docs/GitopsOperator.md:You can install multiple team instances of ArgoCD into different namespaces, just add your namespace to this list. Namespaces will be created first e.g. shown above for a single namespace called `janus-gitops`.
charts/orchestrator-software-templates-infra/docs/GitopsOperator.md:helm uninstall argocd --namespace janus-gitops
charts/orchestrator-software-templates-infra/docs/GitopsOperator.md:oc delete project janus-argocd
docs/external-db.md:- [AWS RDS PostgreSQL](https://github.com/janus-idp/operator/blob/main/docs/external-db.md#aws-rds-postgresql)
docs/external-db.md:- [Azure Database PostgreSQL](https://github.com/janus-idp/operator/blob/main/docs/external-db.md#aws-rds-postgresql)
docs/external-db.md:If you want to move Backstage database from local to external, here is a [Migration Guide](https://github.com/janus-idp/operator/blob/main/docs/db_migration.md).

[rhdh-qodo-merge]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 RHDHBUGS-2159 - Partially compliant Compliant requirements: Rename internal Helm template helper functions to use the rhdh prefix instead of janus-idp Update all references to the renamed helper functions across the chart Update documentation to reflect the new rhdh naming and remove janus-idp mentions Non-compliant requirements: (empty) Requires further human verification: Validate an install/upgrade path for existing users that may still reference the old janus-idp.* helper names (rendering and runtime behavior).

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🔒 No security concerns identified

⚡ Recommended focus areas for review Breaking Change The helper template names were renamed from janus-idp.* to rhdh.*. This is likely a breaking change for any downstream templates or user overrides that still call the old helper names. Consider whether you want to keep backward-compatible aliases (e.g., define janus-idp.hostname that delegates to rhdh.hostname) and/or clearly document the breaking change in release notes. {{- define "rhdh.hostname" -}} {{- if .Values.global.host -}} {{- .Values.global.host -}} {{- else if .Values.global.clusterRouterBase -}} {{- printf "%s-%s.%s" (include "common.names.fullname" .) .Release.Namespace .Values.global.clusterRouterBase -}} {{- else -}} {{ fail "Unable to generate hostname" }} {{- end -}} {{- end -}} {{/* Returns a secret name for service to service auth */}} {{- define "rhdh.backend-secret-name" -}} {{- if .Values.global.auth.backend.existingSecret -}} {{- .Values.global.auth.backend.existingSecret -}} {{- else -}} {{- printf "%s-auth" .Release.Name -}} {{- end -}} {{- end -}} {{/* Sets the secretKeyRef name for Backstage to the PostgreSQL existing secret if it present */}} {{- define "rhdh.postgresql.secretName" -}} {{- if ((((.Values).global).postgresql).auth).existingSecret -}} {{- .Values.global.postgresql.auth.existingSecret -}} {{- else if .Values.postgresql.auth.existingSecret -}} {{- .Values.postgresql.auth.existingSecret -}} YAML Validity The contact_links list structure should be double-checked for correct YAML indentation/list item formatting so GitHub still recognizes the contact link entry. - name: Report Issues on JIRA url: https://issues.redhat.com/browse/RHIDP about: To report issues against this chart, please use JIRA (not GH issues).

📚 Focus areas based on broader codebase context Image Mismatch The chart documentation now states the default image is quay.io/rhdh-community/rhdh:next, but the existing deployment manifests in related components use quay.io/rhdh/rhdh-hub-rhel9:next. Please validate which image is intended as the default for this chart and ensure docs (and any defaults elsewhere) consistently reference that image, or explicitly document why they differ. (Ref 2, Ref 3) | upstream.backstage.initContainers[0].image | Image used by the initContainer to install dynamic plugins into the `dynamic-plugins-root` volume mount. It could be replaced by a custom image based on this one. | string | `quay.io/rhdh-community/rhdh:next` | ## Opinionated Backstage deployment This chart defaults to an opinionated deployment of Backstage that provides user with a usable Backstage instance out of the box. Features enabled by the default chart configuration: 1. Uses [rhdh](https://github.com/redhat-developer/rhdh/) that pre-loads a lot of useful plugins and features 2. Exposes a `Route` for easy access to the instance 3. Enables OpenShift-compatible PostgreSQL database storage For additional instance features please consult the [documentation for `rhdh`](https://github.com/redhat-developer/rhdh/tree/main/showcase-docs). Additional features can be enabled by extending the default configuration at: ```yaml upstream: backstage: appConfig: # Inline app-config.yaml for the instance extraEnvVars: # Additional environment variables Features This charts defaults to using the RHDH image that is OpenShift compatible: quay.io/rhdh-community/rhdh:next **Reference reasoning:** The reference deployment YAMLs consistently use the `quay.io/rhdh/rhdh-hub-rhel9:next` image for the main and init containers, indicating an established convention for the RHDH container image naming/location. Aligning the chart’s documented default with that convention (or documenting the divergence) reduces user confusion and prevents accidental deployments with an unintended image. </details> </td></tr> <tr><td> <details><summary>📄 References</summary><ol><li><a href="https://github.com/redhat-developer/rhdh-chart/blob/bfe3d48/pkg/model/testdata/janus-deployment.yaml/#L1-L35">redhat-developer/rhdh-operator/pkg/model/testdata/janus-deployment.yaml [1-35]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/bfe3d48/pkg/model/testdata/janus-deployment.yaml/#L36-L58">redhat-developer/rhdh-operator/pkg/model/testdata/janus-deployment.yaml [36-58]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/bfe3d48/pkg/model/testdata/janus-deployment.yaml/#L61-L90">redhat-developer/rhdh-operator/pkg/model/testdata/janus-deployment.yaml [61-90]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/1c857b4/pkg/model/testdata/rhdh-deployment.yaml/#L1-L35">redhat-developer/rhdh-operator/pkg/model/testdata/rhdh-deployment.yaml [1-35]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/1c857b4/pkg/model/testdata/rhdh-deployment.yaml/#L36-L58">redhat-developer/rhdh-operator/pkg/model/testdata/rhdh-deployment.yaml [36-58]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/d5d22c9/integration_tests/testdata/rhdh-replace-dynaplugin-root.yaml/#L1-L14">redhat-developer/rhdh-operator/integration_tests/testdata/rhdh-replace-dynaplugin-root.yaml [1-14]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/a6d6217/config/profile/rhdh/kustomization.yaml/#L1-L27">redhat-developer/rhdh-operator/config/profile/rhdh/kustomization.yaml [1-27]</a></li> <li><a href="https://github.com/redhat-developer/rhdh-chart/blob/2c6cef4/dist/rhdh/install.yaml/#L2185-L2194">redhat-developer/rhdh-operator/dist/rhdh/install.yaml [2185-2194]</a></li> </ol></details> </td></tr> </table>

[rhdh-qodo-merge]

PR Code Suggestions ✨

Latest suggestions up to 12976bc

Category	Suggestion	Impact
Possible issue	Add backward-compatible helper aliases To prevent breaking changes for users during upgrades, add aliases for the old janus-idp. helper templates that now point to the new rhdh. helpers. charts/backstage/templates/_helpers.tpl [1-32] {{/* Returns custom hostname */}} {{- define "rhdh.hostname" -}} {{- if .Values.global.host -}} {{- .Values.global.host -}} {{- else if .Values.global.clusterRouterBase -}} {{- printf "%s-%s.%s" (include "common.names.fullname" .) .Release.Namespace .Values.global.clusterRouterBase -}} {{- else -}} {{ fail "Unable to generate hostname" }} {{- end -}} {{- end -}} +{{- define "janus-idp.hostname" -}} + {{- include "rhdh.hostname" . -}} +{{- end -}} {{/* Returns a secret name for service to service auth */}} {{- define "rhdh.backend-secret-name" -}} {{- if .Values.global.auth.backend.existingSecret -}} {{- .Values.global.auth.backend.existingSecret -}} {{- else -}} {{- printf "%s-auth" .Release.Name -}} {{- end -}} {{- end -}} +{{- define "janus-idp.backend-secret-name" -}} + {{- include "rhdh.backend-secret-name" . -}} +{{- end -}} {{/* Sets the secretKeyRef name for Backstage to the PostgreSQL existing secret if it present */}} {{- define "rhdh.postgresql.secretName" -}} {{- if ((((.Values).global).postgresql).auth).existingSecret -}} {{- .Values.global.postgresql.auth.existingSecret -}} {{- else if .Values.postgresql.auth.existingSecret -}} {{- .Values.postgresql.auth.existingSecret -}} + {{- else -}} + {{- printf "%s-postgresql" (include "common.names.fullname" .) -}} + {{- end -}} +{{- end -}} +{{- define "janus-idp.postgresql.secretName" -}} + {{- include "rhdh.postgresql.secretName" . -}} +{{- end -}} Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a breaking change for users upgrading the Helm chart and provides a standard, effective solution to maintain backward compatibility, which is crucial for a good user experience.	Medium
More

---

Previous suggestions

Suggestions up to commit 1f8cf9c

Category	Suggestion	Impact
Incremental [*]	Align documented namespaces consistently Align the namespace in the installation command (rhdh-argocd) with the one in the removal instructions (rhdh-gitops) for consistency. charts/orchestrator-software-templates-infra/docs/GitopsOperator.md [15] -helm upgrade --install argocd . -f values.yaml -n rhdh-argocd --create-namespace +helm upgrade --install argocd . -f values.yaml -n rhdh-gitops --create-namespace Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a critical inconsistency in the documentation between the installation and removal commands, which could lead to user errors and orphaned resources.	Medium

Suggestions up to commit c354a0c

Category	Suggestion	Impact
High-level	This breaking change requires a major version bump The renaming of Helm template functions is a breaking change. A major version bump in the chart's Chart.yaml is required as per semantic versioning to prevent breaking user upgrades. Examples: charts/backstage/templates/_helpers.tpl [4-12] {{- define "rhdh.hostname" -}} {{- if .Values.global.host -}} {{- .Values.global.host -}} {{- else if .Values.global.clusterRouterBase -}} {{- printf "%s-%s.%s" (include "common.names.fullname" .) .Release.Namespace .Values.global.clusterRouterBase -}} {{- else -}} {{ fail "Unable to generate hostname" }} {{- end -}} {{- end -}} charts/backstage/templates/_helpers.tpl [17-23] {{- define "rhdh.backend-secret-name" -}} {{- if .Values.global.auth.backend.existingSecret -}} {{- .Values.global.auth.backend.existingSecret -}} {{- else -}} {{- printf "%s-auth" .Release.Name -}} {{- end -}} {{- end -}} Solution Walkthrough: Before: # charts/backstage/templates/_helpers.tpl {{- define "janus-idp.hostname" -}} ... {{- end -}} # charts/backstage/values.yaml upstream: backstage: appConfig: app: baseUrl: 'https://{{- include "janus-idp.hostname" . }}' # charts/backstage/Chart.yaml (not in PR) # version: x.y.z (unchanged) After: # charts/backstage/templates/_helpers.tpl {{- define "rhdh.hostname" -}} ... {{- end -}} # charts/backstage/values.yaml upstream: backstage: appConfig: app: baseUrl: 'https://{{- include "rhdh.hostname" . }}' # charts/backstage/Chart.yaml (suggested change) # version: (x+1).0.0 (major version bumped) Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies that renaming Helm template functions is a breaking API change, and points out the critical and missing major version bump in Chart.yaml to adhere to semantic versioning.	High
General	Add whitespace control to template Add whitespace control (-) to the Helm include call for rhdh.backend-secret-name to ensure consistent and clean YAML output. docs/external-db.md [81] -name: '{{ include "rhdh.backend-secret-name" $ }}' +name: '{{- include "rhdh.backend-secret-name" $ }}' Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies an inconsistency in Helm template whitespace control, which is a good practice to fix for cleaner output, though it has a minor impact.	Low

[rm3l]

/lgtm

[rhdh-qodo-merge]

Persistent suggestions updated to latest commit 12976bc

[rm3l]

/hold

[rm3l]

Sorry, one more comment as I just realized this.

[rm3l]

/lgtm cancel
/hold cancel

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rm3l]

/lgtm

[rm3l]

/hold cancel