Skip to content

[release-1.10] chore(backstage): pin RHDH image to next-1.10 - #400

Merged
rm3l merged 1 commit into
redhat-developer:release-1.10from
rm3l:chore/pin_rhdh_to_next-1.10_in_release-1.10
May 18, 2026
Merged

[release-1.10] chore(backstage): pin RHDH image to next-1.10#400
rm3l merged 1 commit into
redhat-developer:release-1.10from
rm3l:chore/pin_rhdh_to_next-1.10_in_release-1.10

Conversation

@rm3l

@rm3l rm3l commented May 17, 2026

Copy link
Copy Markdown
Member

Description of the change

Which issue(s) does this PR fix or relate to

  • JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

@rm3l
rm3l requested a review from a team as a code owner May 17, 2026 20:54
@rhdh-qodo-merge

rhdh-qodo-merge Bot commented May 17, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0)

Grey Divider


Remediation recommended

1. Schema template default tag stale 🐞 Bug ⚙ Maintainability
Description
The chart now pins the default image tag to next-1.10 in generated values/schema defaults, but
values.schema.tmpl.json still hardcodes next and the README (and its helm-docs template) still
describe quay.io/rhdh-community/rhdh:next, creating inconsistent defaults and conflicting
guidance. This mismatch risks future drift when generators are rerun and confuses both maintainers
and users about the intended release-1.10 pinning.
Code

charts/backstage/values.schema.json[4916]

+                                    "default": "next-1.10",
Relevance

⭐⭐ Medium

Mixed: team accepted updating values.schema.tmpl.json tag (PR291) but rejected similar “align README
default tag” requests (PR276/291).

PR-#291
PR-#276

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The values.schema.tmpl.json template still contains tag: next even though the committed
generated values.schema.json and values.yaml defaults have been updated to next-1.10; because
the repo’s pre-commit generator explicitly reads values.schema.tmpl.json to render/dereference and
write values.schema.json, leaving the template stale will reintroduce drift. Separately, while
values are pinned to next-1.10, both the rendered README.md and the helm-docs source template
README.md.gotmpl still state the default image is quay.io/rhdh-community/rhdh:next,
contradicting the pinned defaults and ensuring the narrative documentation won’t self-correct unless
the template is updated.

charts/backstage/values.schema.tmpl.json[10-17]
charts/backstage/values.schema.json[4915-4919]
.pre-commit/jsonschema-dereference.py[13-38]
charts/backstage/values.yaml[191-195]
charts/backstage/README.md[278-282]
charts/backstage/README.md[251-251]
charts/backstage/README.md.gotmpl[180-184]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The chart has been updated to pin the default image tag to `next-1.10` (in `values.yaml` and the generated `values.schema.json`), but multiple sources still reference the old default `next`: the schema template (`values.schema.tmpl.json`) hardcodes `"tag": "next"`, and the README (and its helm-docs template) still claim the default image is `quay.io/rhdh-community/rhdh:next`. Align these templates/docs with the pinned default to avoid confusing users and prevent future regeneration from reintroducing drift.

## Issue Context
- A pre-commit hook loads `values.schema.tmpl.json`, renders it, dereferences refs, and writes out `values.schema.json`, so inconsistencies in the template can cause schema drift on regeneration.
- Values now pin the default tag to `next-1.10`.
- Helm-docs uses `charts/backstage/README.md.gotmpl`; even if the generated values table was updated, narrative text in the template will remain wrong until explicitly changed, and `README.md` should then be regenerated/updated accordingly.

## Fix Focus Areas
- charts/backstage/values.schema.tmpl.json[10-17]
- charts/backstage/values.schema.json[4915-4919]
- .pre-commit/jsonschema-dereference.py[13-38]
- charts/backstage/README.md[276-282]
- charts/backstage/README.md.gotmpl[178-184]
- charts/backstage/values.yaml[191-195]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@rm3l rm3l changed the title [release-1.10] chore(backstage): pin RHDH image to next-1.10 in release-1.10 [release-1.10] chore(backstage): pin RHDH image to next-1.10 May 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

Review Summary by Qodo

Pin RHDH image to next-1.10 and bump chart version

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Pin RHDH image tag to next-1.10 for release-1.10 branch
• Update chart version from 5.12.1 to 5.12.2
• Update documentation and schema to reflect new image tag
Diagram
flowchart LR
  A["Chart Version 5.12.1"] -- "bump version" --> B["Chart Version 5.12.2"]
  C["Image Tag: next"] -- "pin to release" --> D["Image Tag: next-1.10"]
  B --> E["Updated Documentation"]
  D --> E
Loading

Grey Divider

File Changes

1. charts/backstage/Chart.yaml ⚙️ Configuration changes +1/-1

Increment chart version for release

• Bumped chart version from 5.12.1 to 5.12.2

charts/backstage/Chart.yaml


2. charts/backstage/README.md 📝 Documentation +3/-3

Update documentation with new version and image tag

• Updated version badge from 5.12.1 to 5.12.2
• Updated helm install command example to use version 5.12.2
• Updated initContainer image tag documentation from next to next-1.10

charts/backstage/README.md


3. charts/backstage/values.schema.json ⚙️ Configuration changes +1/-1

Update schema default image tag

• Updated default image tag from next to next-1.10 in JSON schema

charts/backstage/values.schema.json


View more (1)
4. charts/backstage/values.yaml ⚙️ Configuration changes +2/-2

Pin backstage image tag to next-1.10

• Changed backstage image tag from next to next-1.10
• Updated initContainer image default comment to reflect new tag

charts/backstage/values.yaml


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation enhancement New feature or request labels May 17, 2026
@rm3l
rm3l merged commit 9213e38 into redhat-developer:release-1.10 May 18, 2026
5 of 6 checks passed
@rm3l
rm3l deleted the chore/pin_rhdh_to_next-1.10_in_release-1.10 branch May 18, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant