Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#…

[lholmquist]

…193)"

This reverts commit 64df5e1.

There will be another orchestrator plugin release which will most likely be 1.8.11 and that one should be used instead.

Description

Which issue(s) does this PR fix or relate to

• Fixes #issue_number

PR acceptance criteria

• Tests updated and passing
• Documentation updated
• Built-in TechDocs updated if needed. Note that TechDocs changes may need to be reviewed by a Product Manager and/or Architect to ensure content accuracy, clarity, and alignment with user needs.

How to test changes / Special notes to the reviewer

[rhdh-qodo-merge]

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)

🐞\ ⚙ Maintainability (1)

1. Missing final newline 🐞 ⚙

Description

The updated dynamic plugins YAML is committed without a trailing newline, which git marks explicitly
and which can trigger formatting/lint failures or cause noisy diffs in later edits. This is easy to
fix by ensuring the file ends with a newline.

Code

orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml[R37-42]

+    package: "https://npm.registry.redhat.com/@redhat/backstage-plugin-orchestrator-form-widgets/-/backstage-plugin-orchestrator-form-widgets-1.8.9.tgz"
+    integrity: sha512-fWlawBQUenXQXBUPe04mrIFPhNE05f1aVRJXXFS0FT0doo8X4vijmEeZf4Qm3b1Owgup8E6HHKQr3a94lBrNew==
    pluginConfig:
      dynamicPlugins:
        frontend:
-          red-hat-developer-hub.backstage-plugin-orchestrator-form-widgets: {}
+          red-hat-developer-hub.backstage-plugin-orchestrator-form-widgets: {}

Relevance

⭐⭐⭐ High

Team previously fixed/mentioned adding trailing newline (PR28); missing EOF newline causes noisy
diffs/lint issues.

PR-#28

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The PR diff for this file ends with git’s "No newline at end of file" marker, indicating the last
line (the final plugin config entry) is not newline-terminated.

orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml[37-42]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml` is missing a trailing newline at EOF (git reports `\ No newline at end of file`). This can trip whitespace/format checks and causes noisy diffs.

## Issue Context
This was introduced/retained in the last edited line of the YAML after reverting plugin package versions.

## Fix Focus Areas
- orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml[37-42]

## Proposed fix
Ensure the file ends with a single newline character after the last line.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rhdh-qodo-merge]

Review Summary by Qodo

Revert orchestrator plugins to version 1.8.9

📦 Other

Walkthroughs

Description

• Reverts orchestrator plugins from version 1.8.10 to 1.8.9
• Updates four plugin packages with previous integrity hashes
• Awaiting orchestrator plugin release 1.8.11 for future upgrade

Diagram

flowchart LR
  A["Orchestrator Plugins v1.8.10"] -- "Revert to" --> B["Orchestrator Plugins v1.8.9"]
  B -- "Awaiting" --> C["Future v1.8.11 Release"]

Loading

File Changes

1. orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml Dependencies +9/-9

Revert all orchestrator plugins to 1.8.9

• Downgraded backstage-plugin-orchestrator from 1.8.10 to 1.8.9 with updated integrity hash
• Downgraded backstage-plugin-orchestrator-backend-dynamic from 1.8.10 to 1.8.9 with updated
 integrity hash
• Downgraded backstage-plugin-scaffolder-backend-module-orchestrator-dynamic from 1.8.10 to 1.8.9
 with updated integrity hash
• Downgraded backstage-plugin-orchestrator-form-widgets from 1.8.10 to 1.8.9 with updated
 integrity hash

orchestrator/configs/dynamic-plugins/dynamic-plugins.yaml

---

[rm3l]

Closing for the same reasons mentioned in redhat-developer/rhdh-operator#2661 (comment)

/close

[openshift-ci]

@rm3l: Closed this PR.

Details

In response to this:

Closing for the same reasons mentioned in redhat-developer/rhdh-operator#2661 (comment)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.