Skip to content

Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#… - #2661

Closed
lholmquist wants to merge 1 commit into
redhat-developer:release-1.8from
lholmquist:orchestrator-1.8.10-revert
Closed

Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#…#2661
lholmquist wants to merge 1 commit into
redhat-developer:release-1.8from
lholmquist:orchestrator-1.8.10-revert

Conversation

@lholmquist

Copy link
Copy Markdown
Member

…2646)"

This reverts commit ae1c026.

There will be another orchestrator plugin release which will most likely be 1.8.11 and that one should be used instead.

Description

Which issue(s) does this PR fix or relate to

  • Fixes #issue_number

PR acceptance criteria

  • Tests
  • Documentation

How to test changes / Special notes to the reviewer

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Apr 16, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (1)   📎 Requirement gaps (0)
🐞\ ⚙ Maintainability (1)
📘\ ✧ Quality (1)

Grey Divider


Action required

1. backstage-backend-auth-secret missing manifest 📘
Description
examples/orchestrator-cicd.yaml references the Secret backstage-backend-auth-secret via
spec.application.extraEnvs.secrets, but no Secret resource is defined in the same example bundle.
This makes the example incomplete and can cause kubectl apply -f to fail due to a missing
referenced resource.
Code

examples/orchestrator-cicd.yaml[R121-123]

    extraEnvs:
      secrets:
-        - name: backstage-backend-auth-secret
+        - name: backstage-backend-auth-secret
Relevance

⭐⭐⭐ High

Examples are expected to be runnable/self-contained; similar “missing referenced resource in
examples” fixes were accepted.

PR-#1567
PR-#2307
PR-#2224

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
PR Compliance ID 1 requires that example manifests include stub definitions for any referenced
Secrets/ConfigMaps in the same example set. The changed example manifest references
backstage-backend-auth-secret but does not define a corresponding kind: Secret with that name in
the file.

Rule 1: Include all dependent Kubernetes resources in example manifests
examples/orchestrator-cicd.yaml[121-123]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The example manifest `examples/orchestrator-cicd.yaml` references a Secret named `backstage-backend-auth-secret`, but the Secret is not defined anywhere in the same example bundle.

## Issue Context
This breaks the compliance requirement that examples be self-contained for referenced dependent resources (like Secrets), and it can cause `kubectl apply -f` to fail.

## Fix Focus Areas
- examples/orchestrator-cicd.yaml[110-123]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Missing trailing newline 🐞
Description
config/profile/rhdh/default-config/dynamic-plugins.yaml no longer ends with a trailing newline,
and that exact formatting change propagates into generated bundle/... and dist/... manifests
(embedded string ends without a final \n). This can create avoidable manifest churn during
regeneration and may fail strict YAML/style tooling.
Code

config/profile/rhdh/default-config/dynamic-plugins.yaml[R78-83]

+        package: "@redhat/backstage-plugin-orchestrator-form-widgets@1.8.9"
+        integrity: sha512-fWlawBQUenXQXBUPe04mrIFPhNE05f1aVRJXXFS0FT0doo8X4vijmEeZf4Qm3b1Owgup8E6HHKQr3a94lBrNew==
        pluginConfig:
          dynamicPlugins:
            frontend:
-              red-hat-developer-hub.backstage-plugin-orchestrator-form-widgets: { }
+              red-hat-developer-hub.backstage-plugin-orchestrator-form-widgets: { }
Relevance

⭐⭐⭐ High

Team prioritizes minimizing bundle/dist regeneration noise; trailing newline prevents repeated
manifest diffs (see bundle diff-check workflow work).

PR-#799
PR-#1599
PR-#1374

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The source dynamic plugins ConfigMap ends at the final mapping line without an ending newline, and
the generated artifacts embed the same content without a final newline escape, showing the change is
propagating into shipped manifests. The PR bundle workflow regenerates bundle/dist and will surface
any non-createdAt diffs, so formatting drift here can lead to ongoing auto-regeneration noise.

config/profile/rhdh/default-config/dynamic-plugins.yaml[66-83]
dist/rhdh/install.yaml[2462-2502]
bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml[346-386]
.github/workflows/pr-bundle-diff-checks.yaml[53-62]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`config/profile/rhdh/default-config/dynamic-plugins.yaml` is missing a trailing newline (EOF newline). This propagates into generated artifacts (`dist/rhdh/install.yaml` and `bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml`) as an embedded string that no longer ends with a final `\n`, creating unnecessary manifest drift.

## Issue Context
This repo has a workflow that regenerates bundle/installer manifests and checks diffs (ignoring only `createdAt`). Formatting drift in source config files can therefore cause repeated noisy diffs or unexpected auto-commits.

## Fix Focus Areas
- config/profile/rhdh/default-config/dynamic-plugins.yaml[66-83]
- dist/rhdh/install.yaml[2462-2502]
- bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml[346-386]
- .github/workflows/pr-bundle-diff-checks.yaml[53-62]

## What to change
1. Add a trailing newline at the end of `config/profile/rhdh/default-config/dynamic-plugins.yaml`.
2. Re-run the repository’s manifest generation (`make bundles build-installers`) and commit any resulting updates so `dist/` and `bundle/` stay in sync with the source.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@sonarqubecloud

Copy link
Copy Markdown

Comment on lines 121 to +123
extraEnvs:
secrets:
- name: backstage-backend-auth-secret
- name: backstage-backend-auth-secret No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. backstage-backend-auth-secret missing manifest 📘 Rule violation ✧ Quality

examples/orchestrator-cicd.yaml references the Secret backstage-backend-auth-secret via
spec.application.extraEnvs.secrets, but no Secret resource is defined in the same example bundle.
This makes the example incomplete and can cause kubectl apply -f to fail due to a missing
referenced resource.
Agent Prompt
## Issue description
The example manifest `examples/orchestrator-cicd.yaml` references a Secret named `backstage-backend-auth-secret`, but the Secret is not defined anywhere in the same example bundle.

## Issue Context
This breaks the compliance requirement that examples be self-contained for referenced dependent resources (like Secrets), and it can cause `kubectl apply -f` to fail.

## Fix Focus Areas
- examples/orchestrator-cicd.yaml[110-123]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@rhdh-qodo-merge

Copy link
Copy Markdown

Review Summary by Qodo

Revert orchestrator plugins to version 1.8.9

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Revert orchestrator plugins from version 1.8.10 to 1.8.9
• Update all plugin package versions and integrity hashes
• Update metadata timestamps in operator manifests
• Update documentation and examples to reflect 1.8.9 version
Diagram
flowchart LR
  A["Orchestrator Plugins v1.8.10"] -->|Revert| B["Orchestrator Plugins v1.8.9"]
  B --> C["Update Package Versions"]
  B --> D["Update Integrity Hashes"]
  B --> E["Update Documentation"]
Loading

Grey Divider

File Changes

1. bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml ⚙️ Configuration changes +1/-1

Update operator manifest timestamp

• Updated createdAt timestamp from 2026-04-14 to 2026-03-30

bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml


2. bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml ⚙️ Configuration changes +1/-1

Update RHDH operator manifest timestamp

• Updated createdAt timestamp from 2026-04-14 to 2026-03-30

bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml


3. bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml Dependencies +9/-9

Revert orchestrator plugin versions and hashes

• Downgraded @redhat/backstage-plugin-orchestrator from 1.8.10 to 1.8.9
• Downgraded @redhat/backstage-plugin-orchestrator-backend-dynamic from 1.8.10 to 1.8.9
• Downgraded @redhat/backstage-plugin-scaffolder-backend-module-orchestrator-dynamic from 1.8.10
 to 1.8.9
• Downgraded @redhat/backstage-plugin-orchestrator-form-widgets from 1.8.10 to 1.8.9
• Updated all corresponding integrity SHA512 hashes

bundle/rhdh/manifests/rhdh-default-config_v1_configmap.yaml


View more (5)
4. config/profile/rhdh/default-config/dynamic-plugins.yaml Dependencies +9/-9

Revert orchestrator plugin versions

• Downgraded all four orchestrator plugins from 1.8.10 to 1.8.9
• Updated all integrity SHA512 hashes for each plugin
• Fixed file ending to remove newline

config/profile/rhdh/default-config/dynamic-plugins.yaml


5. dist/rhdh/install.yaml Dependencies +9/-9

Revert orchestrator plugin versions in dist

• Downgraded all four orchestrator plugins from 1.8.10 to 1.8.9
• Updated all corresponding integrity SHA512 hashes
• Fixed file ending formatting

dist/rhdh/install.yaml


6. docs/orchestrator.md 📝 Documentation +5/-5

Update documentation to reflect 1.8.9 version

• Updated version reference from 1.8.10 to 1.8.9 in documentation
• Updated all plugin package version examples from 1.8.10 to 1.8.9

docs/orchestrator.md


7. examples/orchestrator-cicd.yaml Dependencies +5/-5

Revert orchestrator plugin versions in example

• Downgraded all four orchestrator plugins from 1.8.10 to 1.8.9
• Fixed file ending to remove newline

examples/orchestrator-cicd.yaml


8. examples/orchestrator.yaml Dependencies +4/-4

Revert orchestrator plugin versions in example

• Downgraded all four orchestrator plugins from 1.8.10 to 1.8.9
• Fixed file ending formatting

examples/orchestrator.yaml


Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added documentation Improvements or additions to documentation bug_fix labels Apr 16, 2026
@rm3l

rm3l commented Apr 16, 2026

Copy link
Copy Markdown
Member

There will be another orchestrator plugin release which will most likely be 1.8.11 and that one should be used instead.

@lhomquist Are you reverting because the current 1.8.10 orchestrator plugins are broken? If not (and assuming that our 1.8.6 is expected to bump the plugins to 1.8.11 anyway), I'd suggest we just leave them as is on 1.8.10 and just update to 1.8.11 when that version is available. But if 1.8.10 is broken, fine to revert then. WDYT?

@lholmquist

Copy link
Copy Markdown
Member Author

No, not broken, just not the version that will be part of 1.8.6. If you are ok with that, then feel free to close. i also opened PRs to revert for both the rhdh-local and rhdh-charts, i can close those two if you feel like we should close this one

@rm3l

rm3l commented Apr 17, 2026

Copy link
Copy Markdown
Member

No, not broken, just not the version that will be part of 1.8.6. If you are ok with that, then feel free to close. i also opened PRs to revert for both the rhdh-local and rhdh-charts, i can close those two if you feel like we should close this one

In that case, let's close this and create new PRs when 1.8.11 is available. I'll close the other ones as well.

/close

@openshift-ci openshift-ci Bot closed this Apr 17, 2026
@openshift-ci

openshift-ci Bot commented Apr 17, 2026

Copy link
Copy Markdown

@rm3l: Closed this PR.

Details

In response to this:

No, not broken, just not the version that will be part of 1.8.6. If you are ok with that, then feel free to close. i also opened PRs to revert for both the rhdh-local and rhdh-charts, i can close those two if you feel like we should close this one

In that case, let's close this and create new PRs when 1.8.11 is available. I'll close the other ones as well.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug_fix documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants