Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#… - #2661
Revert "[release-1.8] feat: bumping orchestrator plugins to 1.8.10 (#…#2661lholmquist wants to merge 1 commit into
Conversation
Code Review by Qodo
|
|
| extraEnvs: | ||
| secrets: | ||
| - name: backstage-backend-auth-secret | ||
| - name: backstage-backend-auth-secret No newline at end of file |
There was a problem hiding this comment.
1. backstage-backend-auth-secret missing manifest 📘 Rule violation ✧ Quality
examples/orchestrator-cicd.yaml references the Secret backstage-backend-auth-secret via spec.application.extraEnvs.secrets, but no Secret resource is defined in the same example bundle. This makes the example incomplete and can cause kubectl apply -f to fail due to a missing referenced resource.
Agent Prompt
## Issue description
The example manifest `examples/orchestrator-cicd.yaml` references a Secret named `backstage-backend-auth-secret`, but the Secret is not defined anywhere in the same example bundle.
## Issue Context
This breaks the compliance requirement that examples be self-contained for referenced dependent resources (like Secrets), and it can cause `kubectl apply -f` to fail.
## Fix Focus Areas
- examples/orchestrator-cicd.yaml[110-123]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Review Summary by QodoRevert orchestrator plugins to version 1.8.9
WalkthroughsDescription• Revert orchestrator plugins from version 1.8.10 to 1.8.9 • Update all plugin package versions and integrity hashes • Update metadata timestamps in operator manifests • Update documentation and examples to reflect 1.8.9 version Diagramflowchart LR
A["Orchestrator Plugins v1.8.10"] -->|Revert| B["Orchestrator Plugins v1.8.9"]
B --> C["Update Package Versions"]
B --> D["Update Integrity Hashes"]
B --> E["Update Documentation"]
File Changes1. bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml
|
@lhomquist Are you reverting because the current 1.8.10 orchestrator plugins are broken? If not (and assuming that our 1.8.6 is expected to bump the plugins to 1.8.11 anyway), I'd suggest we just leave them as is on 1.8.10 and just update to 1.8.11 when that version is available. But if 1.8.10 is broken, fine to revert then. WDYT? |
|
No, not broken, just not the version that will be part of 1.8.6. If you are ok with that, then feel free to close. i also opened PRs to revert for both the rhdh-local and rhdh-charts, i can close those two if you feel like we should close this one |
In that case, let's close this and create new PRs when 1.8.11 is available. I'll close the other ones as well. /close |
|
@rm3l: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



…2646)"
This reverts commit ae1c026.
There will be another orchestrator plugin release which will most likely be 1.8.11 and that one should be used instead.
Description
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer