Add knative crds + move knative CRs to plugin-infra - #1219
Conversation
|
|
|
@gazarenkov @masayag PTAL |
|
LGTM. |
Thanks! No, I didn't test that. I will test it out and provide feedback. Good point. |
gazarenkov
left a comment
gazarenkov
left a comment
There was a problem hiding this comment.
Please consider to fix https://github.com/redhat-developer/rhdh-operator/blob/main/docs/dynamic-plugins.md#example-orchestrator-plugin-dependencies accordingly.
Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com>
aabcdd8 to
b7fd8d6
Compare
gazarenkov
left a comment
gazarenkov
left a comment
There was a problem hiding this comment.
One more, final ) thing: I think since backstage operator does not deal with knative-eventing and knative-serving anymore we can safely remove
- apiGroups:
- "operator.knative.dev"
resources:
- knativeeventings
- knativeservings
...
block from config/profile/rhdh/plugin-rbac/rbac-sonataflow.yaml ?
Reviewer's GuideThis PR relocates Knative CRs from the plugin-deps profiles into a dedicated plugin-infra manifest, updates the plugin-infra deployment workflow to apply and wait for the new CRs, and refreshes documentation to reflect these changes. Flow diagram for new plugin-infra resource application orderflowchart TD
Start([Start: make plugin-infra])
ApplyServerless[Apply infra-serverless.yaml]
WaitCRDs[Wait for CRDs to be established]
ApplyKnative[Apply infra-knative-cr.yaml]
ApplySonataflow[Apply infra-sonataflow.yaml]
End([End])
Start --> ApplyServerless --> WaitCRDs --> ApplyKnative --> ApplySonataflow --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @jenniferubah - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gazarenkov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry I missed this @gazarenkov. I created the PR here to remove the not needed permissions |
…#1219) * Add knative crds + move knative CRs to plugin-infra * Regenerate bundle/installer manifests Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com> * Fix dynamic plugin doc * Remove serverless crd folder * Update plugin-infra cmd in makefile +location of knative CRs * Remove kustomization file + update makefile cmd * Remove knative namespace creation --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com>
3 participants
Description
Currently, the Knative CRs (managed by Serverless Operator) are created as part of the plugin-deps. However, this should be part of the plugin-infra because there will be risks of failure when changes are made to the these CRs (by the admin) and the RHDH operator attempts reapplication/reconciliation/reversion since the plugin-deps are handled by the operator.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
Knative CRs should be applied during the plugin infrastructure set up instead of afterwards.
Tests
Documentation
How to test changes / Special notes to the reviewer
Pull the changes, run
make plugin-infra deploy IMG={IMG}This should apply the knative CRs and create the resources after the serverless operator is ready.
Summary by Sourcery
Move Knative custom resources setup out of plugin-deps into the plugin-infra directory, adjust the Makefile to deploy and wait for CRDs accordingly, and update documentation to match the new deployment flow.
Enhancements:
Documentation: