Skip to content

Remove unused permission for knative in RBAC - #1320

Merged
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:mainfrom
jenniferubah:rbac-sonataflow-update
Jul 1, 2025
Merged

Remove unused permission for knative in RBAC#1320
openshift-merge-bot[bot] merged 3 commits into
redhat-developer:mainfrom
jenniferubah:rbac-sonataflow-update

Conversation

@jenniferubah

@jenniferubah jenniferubah commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Description

Remove unused RBAC permissions for Knative resources

Which issue(s) does this PR fix or relate to

PR acceptance criteria

  • Tests
  • Documentation

Summary by Sourcery

Enhancements:

  • Remove unused ClusterRole rules for operator.knative.dev resources (knativeeventings and knativeservings) and their verbs.

@sourcery-ai

sourcery-ai Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR streamlines the RBAC configuration by removing an unused Knative apiGroup section from the SonataFlow plugin’s ClusterRole, deleting permissions for knativeeventings and knativeservings resources.

Entity relationship diagram for updated RBAC rules in SonataFlow plugin

erDiagram
    ClusterRole ||--o{ Rule : contains
    Rule {
        string apiGroups
        string resources
        string verbs
    }

    %% Previously, there was a Rule for operator.knative.dev (knativeeventings, knativeservings)
    %% This rule has now been removed, so it is not present in the updated diagram.

    ClusterRole {
        string name
    }
Loading

File-Level Changes

Change Details Files
Removed unused Knative resources permissions
  • Deleted operator.knative.dev apiGroup block
  • Removed knativeeventings and knativeservings resources
  • Removed all associated verbs (create, delete, get, list, patch, update, watch)
config/profile/rhdh/plugin-rbac/rbac-sonataflow.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@openshift-ci
openshift-ci Bot requested review from gazarenkov and rm3l July 1, 2025 00:52

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jenniferubah - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@openshift-ci openshift-ci Bot added the approved label Jul 1, 2025
Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

⚠️ Files changed in bundle and installer generation!

Those changes to the operator bundle/installer manifests should have been pushed automatically to your PR branch.

NOTE: If the PR checks are stuck after this additional commit, manually close the PR and immediately reopen it to trigger the checks again.

@rm3l rm3l closed this Jul 1, 2025
@rm3l rm3l reopened this Jul 1, 2025

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jul 1, 2025
@openshift-ci

openshift-ci Bot commented Jul 1, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gazarenkov, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

@openshift-merge-bot
openshift-merge-bot Bot merged commit 72fe13f into redhat-developer:main Jul 1, 2025
7 checks passed
Fortune-Ndlovu pushed a commit to Fortune-Ndlovu/rhdh-operator that referenced this pull request Sep 6, 2025
* Remove unused permission for knative in rbac

* Regenerate bundle/installer manifests

Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com>
Co-authored-by: Armel Soro <asoro@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants