Remove unused permission for knative in RBAC - #1320
Conversation
Reviewer's GuideThis PR streamlines the RBAC configuration by removing an unused Knative apiGroup section from the SonataFlow plugin’s ClusterRole, deleting permissions for knativeeventings and knativeservings resources. Entity relationship diagram for updated RBAC rules in SonataFlow pluginerDiagram
ClusterRole ||--o{ Rule : contains
Rule {
string apiGroups
string resources
string verbs
}
%% Previously, there was a Rule for operator.knative.dev (knativeeventings, knativeservings)
%% This rule has now been removed, so it is not present in the updated diagram.
ClusterRole {
string name
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @jenniferubah - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com>
|
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gazarenkov, rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
72fe13f
into
redhat-developer:main
* Remove unused permission for knative in rbac * Regenerate bundle/installer manifests Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: jenniferubah <jenniferubah@users.noreply.github.com> Co-authored-by: Armel Soro <asoro@redhat.com>
Description
Remove unused RBAC permissions for Knative resources
Which issue(s) does this PR fix or relate to
PR acceptance criteria
Summary by Sourcery
Enhancements: