fix: Fix the airgap script on ROSA/HyperShift 4.18 by skipping the creation of an IDMS resource - #963
Conversation
This will allow the script to handle situations where there can be limitations on the kind of resources that can be created/updated/deleted
…ontrol planes, like ROSA or HyperShift They actually never worked on such clusters (but were still being created), so it should be safe to skip that part.
…esource on clusters with hosted control planes, like ROSA or HyperShift This also appears to be restricted on such clusters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cherry-pick release-1.6 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.5 |
|
@rm3l: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
rm3l
left a comment
rm3l
left a comment
There was a problem hiding this comment.
Tested successfully on ROSA 4.18, regular OCP, and standard K8s.
|
@rm3l: new pull request created: #968 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rm3l: new pull request created: #969 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…eation of an IDMS resource (redhat-developer#963) * fix: Detect if the OCP cluster has a hosted control plane or not This will allow the script to handle situations where there can be limitations on the kind of resources that can be created/updated/deleted * fix: Skip the creation of the IDMS resource on clusters with hosted control planes, like ROSA or HyperShift They actually never worked on such clusters (but were still being created), so it should be safe to skip that part. * fix: Skip disabling default sources of the cluster-wide OperatorHub resource on clusters with hosted control planes, like ROSA or HyperShift This also appears to be restricted on such clusters
2 participants
Description
As depicted in https://issues.redhat.com/browse/RHIDP-6684, the creation of the IDMS is now being denied by the cluster on ROSA/HyperShift 4.18+
This PR detects the type of cluster (with a hosted control plane or not), and can decide whether to skip creating such forbidden resources.
Which issue(s) does this PR fix or relate to
PR acceptance criteria
How to test changes / Special notes to the reviewer
Create a ROSA 4.18 cluster, and run:
.rhdh/scripts/prepare-restricted-environment.shfrom this PR branch. It should work.It should not affect regular OCP clusters or non-OCP clusters.