Skip to content

[release-1.5] fix: Fix the airgap script on ROSA/HyperShift 4.18 by skipping the creation of an IDMS resource - #969

Merged
rm3l merged 3 commits into
redhat-developer:release-1.5from
openshift-cherrypick-robot:cherry-pick-963-to-release-1.5
Apr 1, 2025
Merged

[release-1.5] fix: Fix the airgap script on ROSA/HyperShift 4.18 by skipping the creation of an IDMS resource#969
rm3l merged 3 commits into
redhat-developer:release-1.5from
openshift-cherrypick-robot:cherry-pick-963-to-release-1.5

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 1, 2025

Copy link
Copy Markdown

This is an automated cherry-pick of #963

Fixes https://issues.redhat.com/browse/RHIDP-6701

/assign rm3l

rm3l added 3 commits April 1, 2025 09:32
This will allow the script to handle situations where
there can be limitations on the
kind of resources that can be created/updated/deleted
…ontrol planes, like ROSA or HyperShift

They actually never worked on such clusters (but were still being created),
so it should be safe to skip that part.
…esource on clusters with hosted control planes, like ROSA or HyperShift

This also appears to be restricted on such clusters

@rm3l rm3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 1, 2025
@openshift-ci

openshift-ci Bot commented Apr 1, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Apr 1, 2025
@rm3l
rm3l merged commit dacf728 into redhat-developer:release-1.5 Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants