Skip to content

feat(intelligent-assistant): Lightspeed Notebook enhancements - #3849

Open
its-mitesh-kumar wants to merge 2 commits into
redhat-developer:mainfrom
its-mitesh-kumar:feat/intelligent-assistant-notebook-ui-improvements
Open

feat(intelligent-assistant): Lightspeed Notebook enhancements#3849
its-mitesh-kumar wants to merge 2 commits into
redhat-developer:mainfrom
its-mitesh-kumar:feat/intelligent-assistant-notebook-ui-improvements

Conversation

@its-mitesh-kumar

@its-mitesh-kumar its-mitesh-kumar commented Jul 19, 2026

Copy link
Copy Markdown
Member

Description

UI/UX improvements for the Lightspeed Notebook, aligned to the prototype and acceptance criteria in RHIDP-14896.

Changes

Notebook card list (AC #1)

  • Humanized document count: "No documents" (zero), "1 document" (singular), "N documents" (plural)
  • Removed extra left padding on card body text for proper alignment

Notebook action menu (AC #2)

  • Added PenIcon to Rename and TrashIcon to Delete dropdown items

Add button icon (AC #3)

  • Changed sidebar "Add" button icon from PlusCircleIcon (filled) to AddCircleOIcon (outline)
  • Moved "Upload a resource" button icon to the left side

Upload modal (AC #4)

  • Title changed to "Add resources"
  • Drag-and-drop text updated to "Drag and drop files here, or click to browse"
  • Replaced plain-text file types with styled chips derived from NOTEBOOK_EXTENSION_TO_FILE_TYPE
  • Added "Supported formats:" label and "Maximum file size is 25 MB." text
  • Upload icon styled with brand/blue color and increased size
  • "Add" button shows count only when files are selected (no more "Add (0)")
  • Entire dropzone area is clickable to browse files (custom DropzoneClickArea component)

Upload modal X button (AC #5)

  • Removed red hover color from file remove button
  • Replaced MUI CloseIcon with PF TimesIcon (12x12px)
  • Changed file item container from solid background to border-only style

Disabled dropzone at file limit (AC #7)

  • Dropzone is now visually disabled (opacity + pointer-events) instead of hidden when 10 files are reached
  • Tooltip on hover shows the max-reached message

Prevent stacked modals (AC #8)

  • Upload modal closes before overwrite modal opens (no more modal stacking)
  • Redesigned overwrite modal: "File already exists" title, warning alert with counts, "Replace existing files" / "Ignore duplicated files" radio options, file list with warning icons on duplicates, "Upload (N)" / "Back" buttons
  • "Back" returns to upload modal with previously selected files preserved

Auto-save on close (AC #9)

  • Empty untitled notebooks are automatically deleted on close
  • Notebooks are kept if name was edited, documents were uploaded, uploads are in progress, or chat was started

Notebook message bar (AC #10)

  • Matched chat's MessageBar design: border, border-radius, pill-shaped buttons
  • Added stop button for ongoing responses (wired to useStopConversation)
  • Added + button (PlusIcon) via additionalActions that directly opens upload modal
  • Added button tooltips for microphone and send

Checklist

  • A changeset describing the change and affected packages
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Enhance AddDocumentModal, OverwriteConfirmModal, NotebookCard, and NotebookView
with improved UX text, document count formatting, file list styling, and fix
translation type errors by removing unnecessary `as any` casts.

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-intelligent-assistant workspaces/intelligent-assistant/plugins/intelligent-assistant patch v3.2.0

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.21239% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.62%. Comparing base (8d3503a) to head (da3844a).
⚠️ Report is 207 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3849      +/-   ##
==========================================
+ Coverage   56.26%   56.62%   +0.36%     
==========================================
  Files        2499     2503       +4     
  Lines       96058    96605     +547     
  Branches    26644    26817     +173     
==========================================
+ Hits        54047    54707     +660     
+ Misses      41683    41567     -116     
- Partials      328      331       +3     
Flag Coverage Δ *Carryforward flag
adoption-insights 83.70% <ø> (ø) Carriedforward from ad01397
ai-integrations 69.00% <ø> (ø) Carriedforward from ad01397
app-defaults 69.79% <ø> (ø) Carriedforward from ad01397
augment 46.39% <ø> (ø) Carriedforward from ad01397
boost 73.13% <ø> (ø) Carriedforward from ad01397
bulk-import 72.46% <ø> (ø) Carriedforward from ad01397
cost-management 14.10% <ø> (ø) Carriedforward from ad01397
dcm 61.81% <ø> (ø) Carriedforward from ad01397
extensions 61.53% <ø> (ø) Carriedforward from ad01397
global-floating-action-button 71.18% <ø> (ø) Carriedforward from ad01397
global-header 59.71% <ø> (ø) Carriedforward from ad01397
homepage 50.23% <ø> (ø) Carriedforward from ad01397
install-dynamic-plugins 56.77% <ø> (ø) Carriedforward from ad01397
intelligent-assistant 73.63% <52.21%> (+4.61%) ⬆️
konflux 91.49% <ø> (ø) Carriedforward from ad01397
lightspeed 69.02% <ø> (ø) Carriedforward from ad01397
mcp-integrations 85.46% <ø> (ø) Carriedforward from ad01397
orchestrator 53.74% <ø> (ø) Carriedforward from ad01397
quickstart 65.63% <ø> (ø) Carriedforward from ad01397
sandbox 79.56% <ø> (ø) Carriedforward from ad01397
scorecard 82.96% <ø> (ø) Carriedforward from ad01397
theme 61.26% <ø> (ø) Carriedforward from ad01397
translations 7.25% <ø> (ø) Carriedforward from ad01397
x2a 78.68% <ø> (ø) Carriedforward from ad01397

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3503a...da3844a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@its-mitesh-kumar its-mitesh-kumar changed the title feat(intelligent-assistant): improve notebook UI components and modals feat(intelligent-assistant): Lightspeed Notebook enhancements Jul 19, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Aug 3, 2026
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot removed the stale label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant