Skip to content

chore(e2e): fix e2e-tests linter and establish linter check - #3332

Merged
openshift-merge-bot[bot] merged 5 commits into
redhat-developer:mainfrom
zdrapela:fix-e2e-tests-linter
Aug 26, 2025
Merged

chore(e2e): fix e2e-tests linter and establish linter check#3332
openshift-merge-bot[bot] merged 5 commits into
redhat-developer:mainfrom
zdrapela:fix-e2e-tests-linter

Conversation

@zdrapela

@zdrapela zdrapela commented Aug 26, 2025

Copy link
Copy Markdown
Member

Description

Our e2e test suite has broken linter settings. This allowed merging files that were not aligned with the configured rules.

This PR fixes the faulty files, fixes the linter settings, and establishes a GitHub action that ensures that linters are used.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
openshift-ci Bot requested review from josephca and psrna August 26, 2025 11:27
@zdrapela zdrapela changed the title chore(fix): e2e-tests linter chore(e2e): fix e2e-tests linter and establish linter check Aug 26, 2025
@zdrapela
zdrapela force-pushed the fix-e2e-tests-linter branch from d09c08b to e167a08 Compare August 26, 2025 12:43
@zdrapela
zdrapela force-pushed the fix-e2e-tests-linter branch from e167a08 to 7805a14 Compare August 26, 2025 12:45
@zdrapela
zdrapela force-pushed the fix-e2e-tests-linter branch from d56a690 to 5c447f6 Compare August 26, 2025 12:49
@gustavolira

Copy link
Copy Markdown
Member

/test e2e-tests

@github-actions

Copy link
Copy Markdown
Contributor

@gustavolira

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 26, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 56d7904 into redhat-developer:main Aug 26, 2025
16 checks passed
zdrapela added a commit to zdrapela/rhdh that referenced this pull request Sep 8, 2025
…eveloper#3332)

* chore(fix): e2e-tests linter

Assisted-by: Cursor

* fixed by Prettier

* Manual fix

Assisted-by: Cursor

* Fix adoption insights

* Create e2e-tests-lint.yaml
openshift-merge-bot Bot pushed a commit that referenced this pull request Sep 9, 2025
* chore(e2e): fix e2e-tests linter and establish linter check (#3332)

* chore(fix): e2e-tests linter

Assisted-by: Cursor

* fixed by Prettier

* Manual fix

Assisted-by: Cursor

* Fix adoption insights

* Create e2e-tests-lint.yaml

* chore(ci): use nounset for CI scripts (#3340)

* chore(ci): use nounset for CI scripts

* Fix sanity checks

* Refactor openshift-ci-tests

* Refactor cleanup

* chore(e2e): attributes for junit (#3333)

* Detect platform and save

* add reportportal/agent-js-playwright

* playwright install chromium

* authentication

* Apply attributes

Assisted-by: Cursor

* Cherry-pick linter

* ok

* Move attributes to beforeall

* Fix junit output definition

* Keep properties

* Fix artifacts url

* JUnit for rehearsals

* Note about GNU grep and GNU sed

Update README.md

* Remove irelevant helper function

* fix artifacts URL for PRs

* tag next

* JOB_TYPE="periodic"

* remove periodic

* Adapt junit file and backup

* Fix

* Fix to use annotations

* Revert "add reportportal/agent-js-playwright"

This reverts commit fa2a088.

* Cursor rule for component assignment

* chore(ci): fix k8s sourcing (#3350)

* chore(e2e): retries for bulk import test (#3367)

* chore(e2e): retries for repo filtering

* Skip if already added

* Logging

* Revert

* Dynamically create the repository

* Update bulk-import.spec.ts

* Update e2e-tests-lint.yaml

* Fix analytics

* tsc

* Update e2e-tests-lint.yaml

* Fix

* Fix chart

* Update utils.sh

* Revert "Update utils.sh"

This reverts commit 2e334dc.

* Fix sanity
guyoron1 pushed a commit to guyoron1/rhdh that referenced this pull request Sep 29, 2025
…eveloper#3332)

* chore(fix): e2e-tests linter

Assisted-by: Cursor

* fixed by Prettier

* Manual fix

Assisted-by: Cursor

* Fix adoption insights

* Create e2e-tests-lint.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants