chore(ci): use nounset for CI scripts - #3340
Conversation
|
Skipping CI for Draft Pull Request. |
4ecf642 to
4844d9a
Compare
|
/test e2e-tests |
|
/test e2e-tests-eks-helm-nightly |
|
/test e2e-tests |
1 similar comment
|
/test e2e-tests |
|
/test e2e-tests |
16ffc66 to
f173b9b
Compare
|
/test e2e-tests |
f173b9b to
ff3c846
Compare
|
/test e2e-tests |
|
/test e2e-tests |
f3e9894 to
90eaa7f
Compare
|
/test e2e-tests-aks-helm-nightly |
|
/test e2e-tests-eks-operator-nightly |
|
/test ? |
|
@zdrapela: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-tests-nightly |
|
/test e2e-tests |
|
/test e2e-tests-nightly |
|
/test e2e-tests |
| # This prevents nounset errors when running locally | ||
| # https://docs.ci.openshift.org/docs/architecture/step-registry/#available-environment-variables | ||
| # https://docs.prow.k8s.io/docs/jobs/#job-environment-variables | ||
| export JOB_NAME="${JOB_NAME:-unknown-job}" |
There was a problem hiding this comment.
these envs could be moved to env_variables.sh
There was a problem hiding this comment.
Hi, I refactored the openshift-ci-tests.sh file more thoroughly. Please see the description for the changes and review again. Thanks!
3e5b28b to
dffd6a9
Compare
dffd6a9 to
4122e75
Compare
|
/test e2e-tests |
|
@zdrapela: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-tests |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c77a47c
into
redhat-developer:main
* chore(ci): use nounset for CI scripts * Fix sanity checks * Refactor openshift-ci-tests * Refactor cleanup
* chore(ci): use nounset for CI scripts * Fix sanity checks * Refactor openshift-ci-tests * Refactor cleanup
* chore(e2e): fix e2e-tests linter and establish linter check (#3332) * chore(fix): e2e-tests linter Assisted-by: Cursor * fixed by Prettier * Manual fix Assisted-by: Cursor * Fix adoption insights * Create e2e-tests-lint.yaml * chore(ci): use nounset for CI scripts (#3340) * chore(ci): use nounset for CI scripts * Fix sanity checks * Refactor openshift-ci-tests * Refactor cleanup * chore(e2e): attributes for junit (#3333) * Detect platform and save * add reportportal/agent-js-playwright * playwright install chromium * authentication * Apply attributes Assisted-by: Cursor * Cherry-pick linter * ok * Move attributes to beforeall * Fix junit output definition * Keep properties * Fix artifacts url * JUnit for rehearsals * Note about GNU grep and GNU sed Update README.md * Remove irelevant helper function * fix artifacts URL for PRs * tag next * JOB_TYPE="periodic" * remove periodic * Adapt junit file and backup * Fix * Fix to use annotations * Revert "add reportportal/agent-js-playwright" This reverts commit fa2a088. * Cursor rule for component assignment * chore(ci): fix k8s sourcing (#3350) * chore(e2e): retries for bulk import test (#3367) * chore(e2e): retries for repo filtering * Skip if already added * Logging * Revert * Dynamically create the repository * Update bulk-import.spec.ts * Update e2e-tests-lint.yaml * Fix analytics * tsc * Update e2e-tests-lint.yaml * Fix * Fix chart * Update utils.sh * Revert "Update utils.sh" This reverts commit 2e334dc. * Fix sanity
* chore(ci): use nounset for CI scripts * Fix sanity checks * Refactor openshift-ci-tests * Refactor cleanup
2 participants
Description
Use
nounsetto make sure all env vars in CI are populated. This prevents issues where tests started to fail because an env var was not set. This was the case with tests different than the usual Helm on OCP.For local development, store the
SHARED_DIRandARTIFACT_DIRin a git-ignored directory.Refactor
openshift-ci-tests.shwith conditional sourcing for jobs and proper ShellCheck sourcing.Refactor GKE cleanup.
Introduce gitignored
env_override.local.shto enable easier local testing and limit the chances of accidentally committing an override.Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer