feat(ci): skip pod log collection on success, write TESTS_PASSED marker - #4267
Merged
openshift-merge-bot[bot] merged 3 commits intoFeb 26, 2026
Merged
Conversation
…ccess On successful PR runs, save_all_pod_logs in testing::check_and_test was collecting logs from every pod in the namespace unconditionally. This adds a condition to skip collection when tests pass, and writes a TESTS_PASSED marker file to $SHARED_DIR on clean exit so that the openshift/release post-phase (gather-extra, must-gather) can skip heavy artifact collection. Ref: RHIDP-12291 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The image is available at: |
gustavolira
added a commit
to gustavolira/release
that referenced
this pull request
Feb 18, 2026
Replace `chain: gather` with an RHDH-specific gather step for the e2e-ocp-helm PR check job. The new step checks for a TESTS_PASSED marker in $SHARED_DIR (written by the RHDH test scripts on exit 0). On success: skips must-gather and gather-extra entirely (~8 min savings). On failure: runs must-gather and collects essential cluster state (operators, nodes, pods, events, RHDH namespace logs). This change only affects the RHDH e2e-ocp-helm PR job. Nightly jobs retain the full generic gather chain. Companion PR: redhat-developer/rhdh#4267 Ref: RHIDP-12291 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gustavolira
added a commit
to gustavolira/release
that referenced
this pull request
Feb 18, 2026
Replace `chain: gather` with an RHDH-specific gather step for the e2e-ocp-helm PR check job. The new step checks for a TESTS_PASSED marker in $SHARED_DIR (written by the RHDH test scripts on exit 0). On success: skips must-gather and gather-extra entirely (~8 min savings). On failure: runs must-gather and collects essential cluster state (operators, nodes, pods, events, RHDH namespace logs). This change only affects the RHDH e2e-ocp-helm PR job. Nightly jobs retain the full generic gather chain. Companion PR: redhat-developer/rhdh#4267 Ref: RHIDP-12291 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gustavolira
added a commit
to gustavolira/release
that referenced
this pull request
Feb 18, 2026
Replace `chain: gather` with an RHDH-specific gather step for the e2e-ocp-helm PR check job. The new step checks for a TESTS_PASSED marker in $SHARED_DIR (written by the RHDH test scripts on exit 0). On success: skips must-gather and gather-extra entirely (~8 min savings). On failure: runs must-gather and collects essential cluster state (operators, nodes, pods, events, RHDH namespace logs). This change only affects the RHDH e2e-ocp-helm PR job. Nightly jobs retain the full generic gather chain. Companion PR: redhat-developer/rhdh#4267 Ref: RHIDP-12291 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
check_backstage_running already calls save_all_pod_logs internally before returning false. Only call save_all_pod_logs when deployment succeeded but tests failed — skip both when deployment failed (already collected) and when tests passed (not needed). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
gustavolira
added a commit
to gustavolira/release
that referenced
this pull request
Feb 19, 2026
Replace `chain: gather` with an RHDH-specific gather step for the e2e-ocp-helm PR check job. The new step checks for a TESTS_PASSED marker in $SHARED_DIR (written by the RHDH test scripts on exit 0). On success: skips must-gather and gather-extra entirely (~8 min savings). On failure: runs must-gather and collects essential cluster state (operators, nodes, pods, events, RHDH namespace logs). This change only affects the RHDH e2e-ocp-helm PR job. Nightly jobs retain the full generic gather chain. Companion PR: redhat-developer/rhdh#4267 Ref: RHIDP-12291 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Per review feedback: check_backstage_running is only called from check_and_test, so pod log collection belongs in the caller. This removes the _deployment_failed flag and centralizes the decision in check_and_test using STATUS_TEST_FAILED/STATUS_FAILED_TO_DEPLOY. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: subhashkhileri The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
jrichter1
approved these changes
Feb 25, 2026
openshift-merge-bot
Bot
deleted the
qe/conditional-gather-skip-on-success
branch
February 26, 2026 01:10
This was referenced Apr 17, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_all_pod_logsintesting::check_and_test()when tests pass — avoids iterating all pods in the namespace on successful runsTESTS_PASSEDmarker to$SHARED_DIRon clean exit (OVERALL_RESULT=0) so the openshift/release post-phase steps (gather-extra,must-gather) can detect success and skip heavy artifact collection (~8 min savings)Changes
.ibm/pipelines/lib/testing.sh—testing::check_and_test():_deployment_failedflagsave_all_pod_logswhen deployment failed orSTATUS_TEST_FAILEDis true.ibm/pipelines/cleanup.sh—cleanup():OVERALL_RESULT, write$SHARED_DIR/TESTS_PASSEDmarker if result is 0gather-extraandmust-gatherFollow-up
A separate PR to openshift/release is needed to check for the
TESTS_PASSEDmarker in the gather-extra step and skip collection when present. That PR will unlock the full ~7-8 min savings per successful PR run.Test plan
TESTS_PASSEDmarker exists in$SHARED_DIRTESTS_PASSEDmarker is NOT writtencheck_backstage_running+check_and_testfailure pathrun_tests)Ref: RHIDP-12291
🤖 Generated with Claude Code