Skip to content

fix: rebuild isolate runner handle before starting runner socket#1376

Closed
MasterPtato wants to merge 1 commit into
11-18-fix_update_ds_state_when_failed_to_allocatefrom
11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket
Closed

fix: rebuild isolate runner handle before starting runner socket#1376
MasterPtato wants to merge 1 commit into
11-18-fix_update_ds_state_when_failed_to_allocatefrom
11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket

Conversation

@MasterPtato
Copy link
Copy Markdown
Contributor

@MasterPtato MasterPtato commented Nov 18, 2024 •
edited
Loading

Fixes RVT-4093

Changes

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Nov 18, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6a310b
Status:🚫  Build failed.

View logs

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Nov 18, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Nov 18, 2024
Closed
Closed
@linear
Copy link
Copy Markdown

linear Bot commented Nov 18, 2024

RVT-4093 Clients spawn WebSockets when unable to connect to runner

This was referenced Nov 18, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Copy Markdown
Contributor Author

MasterPtato commented Nov 18, 2024 •
edited by NathanFlurry
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Nov 18, 2024
Closed
@MasterPtato MasterPtato force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from a27ea00 to 163bf1f Compare November 19, 2024 00:15
@MasterPtato MasterPtato force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from be2641f to 59ba78a Compare November 19, 2024 00:15
This was referenced Nov 19, 2024
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from 163bf1f to 738afd2 Compare November 19, 2024 19:15
@MasterPtato MasterPtato force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 59ba78a to 5d67867 Compare November 19, 2024 19:15
This was referenced Nov 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from 738afd2 to c65832f Compare November 20, 2024 18:58
@MasterPtato MasterPtato force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 5d67867 to 7849696 Compare November 20, 2024 18:58
@MasterPtato MasterPtato force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from c65832f to 48565f3 Compare November 20, 2024 19:28
@MasterPtato MasterPtato force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 7849696 to 47f9a25 Compare November 20, 2024 19:28
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from 48565f3 to 12f7a23 Compare November 21, 2024 01:49
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 47f9a25 to 97489da Compare November 21, 2024 01:49
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from 12f7a23 to df23ff6 Compare November 21, 2024 02:02
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 97489da to 661abbc Compare November 21, 2024 02:03
@MasterPtato MasterPtato force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from df23ff6 to 2790937 Compare November 21, 2024 02:42
@MasterPtato MasterPtato force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 661abbc to 67eafcb Compare November 21, 2024 02:42
@MasterPtato MasterPtato mentioned this pull request Nov 21, 2024
Closed
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from 2790937 to 32052cf Compare November 21, 2024 09:11
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from 67eafcb to fe4a0e2 Compare November 21, 2024 09:11
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_update_ds_state_when_failed_to_allocate branch from 32052cf to b3c53bc Compare November 21, 2024 20:53
@NathanFlurry NathanFlurry force-pushed the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch from fe4a0e2 to e6a310b Compare November 21, 2024 20:53
@NathanFlurry NathanFlurry mentioned this pull request Nov 21, 2024
Closed
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Nov 21, 2024 •
edited
Loading

Merge activity

  • Nov 21, 3:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 3:58 PM EST: CI is running for this PR on a draft PR: #1425
  • Nov 21, 4:00 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1425.

NathanFlurry pushed a commit that referenced this pull request Nov 21, 2024
@MasterPtato
fix: rebuild isolate runner handle before starting runner socket (#1376)
cdda797 
<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-4093
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app Bot closed this Nov 21, 2024
@graphite-app graphite-app Bot deleted the 11-18-fix_rebuild_isolate_runner_handle_before_starting_runner_socket branch November 21, 2024 21:00
@github-actions github-actions Bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MasterPtato @NathanFlurry