fix: add hosts file to runc#1386
Closed
MasterPtato wants to merge 1 commit into
Closed
Conversation
Deploying rivet with
|
| Latest commit: |
a0c1c13
|
| Status: | 🚫 Build failed. |
Contributor
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Nov 19, 2024
Closed
This was referenced Nov 19, 2024
Closed
Closed
Closed
Closed
Contributor
Author
This was referenced Nov 19, 2024
Closed
MasterPtato
force-pushed
the
11-19-fix_remove_cgroups_from_pb_manager
branch
from
f1e6888 to
82dbfb2
Compare
MasterPtato
force-pushed
the
11-19-fix_add_hosts_file_to_runc
branch
from
5a7511c to
f91c159
Compare
MasterPtato
force-pushed
the
11-19-fix_remove_cgroups_from_pb_manager
branch
from
82dbfb2 to
b7b1edd
Compare
MasterPtato
force-pushed
the
11-19-fix_add_hosts_file_to_runc
branch
from
f91c159 to
e28775a
Compare
MasterPtato
force-pushed
the
11-19-fix_remove_cgroups_from_pb_manager
branch
from
b7b1edd to
ef8e1a0
Compare
MasterPtato
force-pushed
the
11-19-fix_add_hosts_file_to_runc
branch
from
e28775a to
941a5f7
Compare
NathanFlurry
previously requested changes
Nov 21, 2024
| "source": actor_path.join("resolv.conf").to_str().context("resolv.conf path")?, | ||
| "options": ["rbind", "rprivate"] | ||
| })); | ||
| mounts.push(json!({ |
Member
There was a problem hiding this comment.
I think the file needs to be manually written to the OCI bundle instead of mounted.
The hosts file is mutable (ie you can add a new host with echo '...' >> /etc/hosts) and i don't think mounting works
NathanFlurry
force-pushed
the
11-19-fix_remove_cgroups_from_pb_manager
branch
from
ef8e1a0 to
391850e
Compare
NathanFlurry
force-pushed
the
11-19-fix_add_hosts_file_to_runc
branch
from
941a5f7 to
6cdba87
Compare
NathanFlurry
force-pushed
the
11-19-fix_remove_cgroups_from_pb_manager
branch
from
391850e to
644f7f1
Compare
NathanFlurry
force-pushed
the
11-19-fix_add_hosts_file_to_runc
branch
from
6cdba87 to
a0c1c13
Compare
Contributor
Merge activity
|
NathanFlurry
pushed a commit
that referenced
this pull request
Nov 21, 2024
<!-- Please make sure there is an issue that this PR is correlated to. --> Fixes RVT-4074 ## Changes <!-- If there are frontend changes, please include screenshots. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RVT-4074
Changes