Fix experiment 'name' scope#1258
Merged
krzentner merged 1 commit intorlworkgroup:masterfrom Mar 26, 2020
gagkhan:fix_wrap_expt
Merged
Fix experiment 'name' scope#1258krzentner merged 1 commit intorlworkgroup:masterfrom gagkhan:fix_wrap_expt
krzentner merged 1 commit intorlworkgroup:masterfrom
gagkhan:fix_wrap_expt
Conversation
Set name for log prefix even if log_dir is not used.
krzentner
approved these changes
Mar 26, 2020
Contributor
krzentner
left a comment
krzentner
left a comment
There was a problem hiding this comment.
Oh, thanks! I should really have a test that sets logdir.
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
===========================================
- Coverage 88.45% 75.89% -12.57%
===========================================
Files 194 194
Lines 9553 9553
Branches 1215 1215
===========================================
- Hits 8450 7250 -1200
- Misses 876 2095 +1219
+ Partials 227 208 -19
Continue to review full report at Codecov.
|
Contributor
Author
|
Great. Thanks KR & ZP! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix leaves
namein scope for use here@zhanpenghe @krzentner