Skip to content

Fix experiment 'name' scope #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krzentner merged 1 commit into from
Mar 26, 2020
Merged

Fix experiment 'name' scope #1258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix experiment 'name' scope 
Set name for log prefix even if log_dir is not used.
  • Loading branch information
@gagkhan
gagkhan committed Mar 26, 2020
commit 84d9afd41c4d3451736f0140eacc647eae9204ae
6 changes: 3 additions & 3 deletions src/garage/experiment/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,11 +388,11 @@ def _make_context(self, *args, **kwargs):
if args:
raise ValueError('garage.experiment currently only supports '
'keyword arguments')
name = self.name
if name is None:
name = self.function.__name__
log_dir = self.log_dir
if log_dir is None:
name = self.name
if name is None:
name = self.function.__name__
log_dir = ('{data}/local/{prefix}/{name}'.format(
data=os.path.join(os.getcwd(), 'data'),
prefix=self.prefix,
Expand Down